Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ItemModelBase._storeData easier to override #101

Open
jonathanj opened this issue Jan 5, 2016 · 0 comments
Open

make ItemModelBase._storeData easier to override #101

jonathanj opened this issue Jan 5, 2016 · 0 comments

Comments

@jonathanj
Copy link
Member

Even though ItemModelBase._storeData is designate a private method (perhaps something that change), in my experience in often needs to be overridden instead of its related method, ItemModelBase.storeData in order to maintain the correct SQL transaction behavior.

Overriding this method is unnecessarily quirky, however, because ItemModelBase.storeData passes its data as an actual Python dictionary as opposed to unpacked keyword arguments a la standard Python convention.

It is very helpful in the common (at least for me) case of slightly tweaking the behavior of ItemModelBase._storeData to be able to "peel off" some of the keyword arguments passed in from the form invocation and manipulate them as needed before issuing a cooperative super() call on _storeData.

@jonathanj jonathanj added New and removed Undecided labels Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant