Can not load a book from manifest.json

[miendinh]

I tried epub.js 0.3.66 with this examples

1. https://github.com/futurepress/epub.js/blob/master/examples/manifest.html
2. https://s3.amazonaws.com/epubjs-manifest/examples/manifest.html?href=https://readium2.now.sh/pub/L2hvbWUvbm93dXNlci9zcmMvbWlzYy9lcHVicy9jaGlsZHJlbnMtbGl0ZXJhdHVyZS5lcHVi/manifest.json

they seem not to work and don't show any error logs.

are there any bugs in v.0.3.66 ?

thanks

[danielweck]

Note that the latest "Readium webpub manifest" specification introduced a breaking change: 'spine' was renamed 'readingOrder' (to align with W3C Web Publications)

The r2-streamer-js server generates this new syntax, so every existing reading system (such as EPUBjs) that implements support for the Readium JSON manifest must update their code accordingly.

Could this be the root cause of the problem here?

CC @JayPanoz

[danielweck]

Yes, it looks like the EPUBjs code looks for 'spine' instead of 'readingOrder' when parsing the manifest JSON:

'this.spine = json.spine.map( ... )'

https://github.com/futurepress/epub.js/blob/v0.4/src/epub/packaging.js

[danielweck]

CC @HadrienGardeur

Note that the 'webpub-viewer' demo must be updated too:

'manifest.spine.map( ... )'

https://github.com/HadrienGardeur/webpub-viewer/blob/master/viewer.js.

[danielweck]

@jccr is the EvidentPoint reader up to date with respect to the 'spine' vs. 'readingOrder' renaming?

[danielweck]

@jccr
if I am not mistaken you guys rely on the TypeScript ta-json (de)serialisation framework from r2-shared-js models, so you should "automatically" be up to date next time you synchronize with the upstream code.

https://github.com/evidentpoint/r2-shared-js/blob/develop/src/models/publication.ts

https://github.com/evidentpoint/r2-navigator-web/blob/master/src/streamer/publication.ts

[danielweck]

Fred (@futurepress), sorry to populate this issue with a global status update on "webpub manifest" support, but I think it is important that we achieve interoperability across reading systems. My apologies if this is off-the-mark.

@NYPL-Simplified

Same problem here:
'this.spine = manifestJSON.spine'

https://github.com/NYPL-Simplified/webpub-viewer/blob/master/src/Manifest.ts

I think the best move forward is to implement backward-compatible JSON parsing ('spine' and 'readingOrder'), because not all instances of Readium 2 "streamer" serve the updated webpub manifest syntax, and some integrations might still be using an old r2-streamer-js revision.

@HadrienGardeur, what do you think?

[JayPanoz]

FWIW, that’s what I was going to (temporarily?) do indeed as we’re in server update mode right now and supporting both is not too much overhead – while providing some flexibility just in case we need to roll back for some reason.

[jccr]

@danielweck
I'm in the process of updating our forks to upstream. Thanks for the heads up.

[fchasen]

@danielweck - Thanks for bring this to my attention!

I've updated v0.3 & v0.4 to use either manifest.readingOrder or manifest.spine but I still need to figure out if I should rename all the spine related methods / classes. I've always like the term.

Will publish to npm after that is sorted.

[JayPanoz]

@danielweck done in our NYPL fork, no issue to report – thanks again for helping by mail. 👍

[HadrienGardeur]

@danielweck I have a lot on my plate right now so I probably won't be able to handle this before a while in my prototype.

If you have the opportunity to handle it before me, I'll definitely accept the PR though.

[danielweck]

Thanks for the quick fix @fchasen :)

Note that the demo page:
https://s3.amazonaws.com/epubjs-manifest/examples/manifest.html?href=https://readium2.now.sh/pub/L2hvbWUvbm93dXNlci9zcmMvbWlzYy9lcHVicy9jaGlsZHJlbnMtbGl0ZXJhdHVyZS5lcHVi/manifest.json

...has not been updated with the latest code yet:
7fd362b

[danielweck]

@HadrienGardeur I created PRs: HadrienGardeur/webpub-viewer#7 and HadrienGardeur/webpub-manifest#3

[danielweck]

@NYPL-Simplified I crated a PR: NYPL-Simplified/webpub-viewer#139

[fchasen]

Updated the demo, going to close this for now.

Thanks all!