Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree breaks if message definition changes #29

Open
Oberacda opened this issue Dec 18, 2023 · 1 comment
Open

Tree breaks if message definition changes #29

Oberacda opened this issue Dec 18, 2023 · 1 comment
Assignees
Labels
bug Something isn't working Core Library Issues concerning the core BT library. Medium Priority question Further information is requested

Comments

@Oberacda
Copy link
Contributor

When a tree has an explicit message definition inside of it (constant, etc.), the tree will break if the message is updated to have more fields. The changed message definition is already caught by bt_py, so why not offer some sort of migration?

@Oberacda Oberacda added bug Something isn't working Core Library Issues concerning the core BT library. Medium Priority labels Dec 18, 2023
@Oberacda Oberacda added the question Further information is requested label Jul 25, 2024
@Oberacda
Copy link
Contributor Author

During the discussion, some questions emerged that require additional testing:

  • Do existing connections break if new fields are added to a message/service/action, but the connected ones are unchanged?
  • Do existing connections break if the field is removed from the message?
  • Can we automatically fix/migrate the tree to alleviate these issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Core Library Issues concerning the core BT library. Medium Priority question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants