Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend 'description' of the core-source 'Entity' class #106

Open
mbrush opened this issue Oct 4, 2022 · 0 comments
Open

Amend 'description' of the core-source 'Entity' class #106

mbrush opened this issue Oct 4, 2022 · 0 comments

Comments

@mbrush
Copy link
Contributor

mbrush commented Oct 4, 2022

The description of the core-source Entity class was borrowed from the definition of the va-spec Entity class:

Entity is the root class of ‘core’ classes model - those that have identifiers and other general
metadata like labels, xrefs, urls, descriptions, etc. All core classes descend from and inherit
its attributes.

But Entity is used differently in the core-source model, and this definition not consistent its use here. (e.g. not all core-source.Entities have the general metadata types mentioned in the description above)

Note that we may want to resolve issue #110 concerning broader alignment of high level class structures between core-source and the va-spec, before finalizing the definition of the Entity class here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant