Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent use of 'Condition' (vs 'Disease') #188

Open
mbrush opened this issue Aug 30, 2024 · 2 comments
Open

Consistent use of 'Condition' (vs 'Disease') #188

mbrush opened this issue Aug 30, 2024 · 2 comments
Assignees

Comments

@mbrush
Copy link
Contributor

mbrush commented Aug 30, 2024

Noting that we use both terms 'condition' and 'disease' in attribute names and class/attribute descriptions, across the different statement profile files. I assume that the inconsistent use of the terms in attribute names and class/attribute descriptions across various profiles is unintentional.

I recommend that we update these to use the broadest term 'condition' in all cases (unless there is reason to sue a more specific term like 'disease' or 'tumor') - so that we are clear and consistent here. Esp since our model makes an explicit distinction between Condition and Disease classes.

@larrybabb
Copy link
Contributor

I agree with the recommendation. To be clear though, the term Condition is specifically defined to be either a Disease a Phenotype or a TraitSet. And a TraitSet is a term from clinvar that can be 2 or more items of a Disease and/or Phenotype. If we are going to do any major redefining of Condition let's coordinate this with the clinvar implementation so we do not break it.

@mbrush
Copy link
Contributor Author

mbrush commented Sep 12, 2024

Hi Larry. This is how I understand things as well. I will make a PR with updates to labels and text to be consistent with the modeling.

If this requires downstream work to update data or models - we can wait to push this until after the Connect meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants