Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom registry and tagging images #87

Open
haadr opened this issue Aug 16, 2023 · 0 comments
Open

Custom registry and tagging images #87

haadr opened this issue Aug 16, 2023 · 0 comments

Comments

@haadr
Copy link

haadr commented Aug 16, 2023

Having a tag like

tag = my/great/image:pyrex-v2

and a registry like

registry = ghcr.io

When I build my image, the resulting docker image will be named/tagged as my/great/image:pyrex-v2, ie. without the registry information. AFAICT I then need to make sure that I or my users do not push it to docker.io by mistake, since that's the default registry.

When I let pyrex pull my image automatically (via whisk) the image will be named/tagged as ghcr.io/my/great/image:pyrex-v2.

Ideally I'd like my image to always contain the custom registry in its tag, even when built myself. But I don't see how I can do that without modifying pyrex's source. If I prepend the tag with my registry this will let me build a correctly-tagged image, but during fetching pyrex will prepend the registry yet again to the tag and try to fetch an image tagged ghcr.io/ghcr.io/my/greate/image....

Of course we can simply patch pyrex to always prepend the registry even when building locally and make sure to not append it if the user prepended it manually in pyrex.ini.

Do you have any thoughts about this? I'd like to minimize the risk of things being pushed to docker.io by mistake. Maybe a small thing, but 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant