Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-hidapi.sh: Remove calls to "make clean" #122

Closed
tresf opened this issue Aug 11, 2021 · 1 comment
Closed

build-hidapi.sh: Remove calls to "make clean" #122

tresf opened this issue Aug 11, 2021 · 1 comment

Comments

@tresf
Copy link
Contributor

tresf commented Aug 11, 2021

Some targets in build-hidapi.sh will fail when make clean is called with the error:

- make: *** No rule to make target `clean'.  Stop.

I propose we abolish all calls to make clean in build-hidapi.sh in favor of reseting the hidapi git repository between builds.

Example:

function git-clean {
  echo -e "Resetting Cpp/hidapi"
  git clean -ffdx > /dev/null 2>&1 || exit   # remove all untracked files
  git reset --hard > /dev/null 2>&1 || exit  # reset all tracked files
}
- echo -e "${green}Building Windows 64-bit${plain}"
+ echo -e "${green}Building Windows 64-bit${plain}" && git-clean
   dockcross-windows-shared-x64 bash -c 'sudo apt-get update && sudo apt-get --yes install libudev-dev libusb-1.0-0-dev && sudo ./bootstrap && sudo ./configure --host=x86_64-w64-mingw32 && sudo make'
// ...
tresf added a commit to tresf/hid4java that referenced this issue Aug 11, 2021
tresf added a commit to tresf/hid4java that referenced this issue Aug 11, 2021
tresf added a commit to tresf/hid4java that referenced this issue Aug 11, 2021
@gary-rowe
Copy link
Owner

@tresf I've added the git-clean function to the build-hidapi.sh script in develop so I think this issue can be closed now. Thank you for submitting it 😁

gary-rowe added a commit that referenced this issue Dec 5, 2022
* #93 Create placeholder for hidapi win32-aarch64

* #93 Add POM version for local JNA issue 93 support

* #93 Add POM version for JNA 5.7.0-SNAPSHOT

* #93 Add local library reference for faster JNA turnaround

* #93 Re-instate missing DLL and reference JNA-5.7.0-SNAPSHOT

* Fix buld-hidapi.sh
Closes #114
Make colors easier to read in the shell script

* Add win32-aarch64 to dockcross

* Fix JNA dependency

* Fix unit test
Wait 30s for testing as logs indicate

* Add darwin-aarch64 to dockcross

* Bump JNA to 5.8.0

* Switch darwin to new jna suffix
Also adds some sanitization to the build-hidapi.sh

* Quality of life improvements :)

* Fix missing dollar sign

* Remove problematic calls to "make clean"
Closes #122

* Add hints for SDKROOT, MACOSX_DEPLOYMENT_TARGET
Closes #120

Co-authored-by: Gary Rowe <g.rowe@froot.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants