Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to MacOS builds #116

Merged
merged 16 commits into from
Dec 5, 2022
Merged

Conversation

tresf
Copy link
Contributor

@tresf tresf commented Jul 20, 2021

Note before merging: This PR contains commits from #115, but they can be refactored out once that branch is merged into develop.

Relevant commits:

Related #108

@tresf tresf changed the base branch from develop to issue-108 July 20, 2021 21:35
build-hidapi.sh Outdated Show resolved Hide resolved
@DaPutzy
Copy link
Contributor

DaPutzy commented Nov 19, 2022

Hi! I opened this issue a couple days ago and created a little patch to add the "non-exclusive device open mode" for mac os.

I feel like this would be a great addition to this PR!

It does require libhidapi > 0.12.0 though, and I don't think that is the version currently used in this PR.
I could not figure out where the version is actually coming from though?

@tresf
Copy link
Contributor Author

tresf commented Nov 19, 2022

Hi! I opened this issue a couple days ago and created a little patch to add the "non-exclusive device open mode" for mac os.

Thanks! Can you please open a separate PR for this patch?

I feel like this would be a great addition to this PR!

Since it modifies the default behavior I think it should be separate for better tracking, but it definitely improves the quality of life for MacOS users.

I haven't read the PR patch yet, but many applications will want to maintain exclusive access, so I would recommend (if not already) that the PR has an API toggle for this behavior.

It does require libhidapi > 0.12.0 though, and I don't think that is the version currently used in this PR. I could not figure out where the version is actually coming from though?

AFAIR, the build system always uses the latest version from upstream.

@DaPutzy
Copy link
Contributor

DaPutzy commented Nov 19, 2022

I implemented a toggle and the default behaviour is the same as before :)

I build this on top of your PR but i just noticed you only changed the build anyway so there should be no issue creating a separate PR.

@DaPutzy
Copy link
Contributor

DaPutzy commented Nov 20, 2022

Created a new PR as discussed 👍

@gary-rowe gary-rowe merged commit ef4c5f7 into gary-rowe:issue-108 Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants