Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When inferring types for the graphql schema, log when we discard a field due to conflicting types #3856

Closed
KyleAMathews opened this issue Feb 4, 2018 · 4 comments
Assignees

Comments

@KyleAMathews
Copy link
Contributor

Currently we just silently discard the field which causes confusion as the field just disappears. We should instead log out what happened and the fields that conflict.

@pieh pieh self-assigned this Feb 4, 2018
@pieh pieh added the DX label Feb 4, 2018
@pieh
Copy link
Contributor

pieh commented Feb 4, 2018

Note to self: log it just once as we extract example fields 4 times ( 2 schema generation x (field type + field input types) )

@cricrio
Copy link
Contributor

cricrio commented Feb 10, 2018

Isn't this issue the same as #2405? Because I was willing to do it but it seems really close this issue.

@pieh
Copy link
Contributor

pieh commented Feb 10, 2018

Yeah, it's same thing. Sometimes hard to keep track of things when there is single Issues tab for all kinds of things (feature request, bug reports, etc) and not everything is labeled :)

You are welcome to join conversation on linked PR ( #3905 )

@m-allanson m-allanson removed the review label Apr 13, 2018
@m-allanson
Copy link
Contributor

Closing as a duplicate of #2405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants