Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DART restitution coefficient not working #2904

Open
axkoenig opened this issue Dec 11, 2020 · 1 comment
Open

DART restitution coefficient not working #2904

axkoenig opened this issue Dec 11, 2020 · 1 comment

Comments

@axkoenig
Copy link

Hi,

I am using Gazebo 11 and the DART physics engine. I would like to alter the amount of restoring force and damping that is applied when two models in my simulation collide. As I understand this can be altered with the <restitution_coefficient> tag in my SDF. Please correct me if I'm wrong.

I noticed, however, that Gazebo 11 currently ignores the <restitution_coefficient> defined under <bounce> in the SDF. This should be an easy fix. Instead of working with the default DART properties defined here, we could parse at least the <restitution_coefficient> from the SDF and hand it to the constructor.

Note that there is a similar PR open in the IgnitionPhysics repo. Is there an easy way to integrate this change?

@azeey
Copy link
Collaborator

azeey commented Dec 11, 2020

It would be nice to add this, but we can't directly take the changes from ign-physics and apply them here. We would need to add a restitution_coefficient variable to DARTSurfaceParamsPrivate.hh and populate it from SDF in DARTSurfaceParams.cc and apply it to the body node in https://github.com/osrf/gazebo/blob/63d11b695134c7075161f1bdc36b91db47f27f92/gazebo/physics/dart/DARTLink.cc#L249

We would definitely welcome a PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants