Fix finding GzProtobuf to support version 4.23.2 #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
Codecov Report
@@ Coverage Diff @@
## ign-sensors6 #351 +/- ##
=============================================
Coverage 73.78% 73.78%
=============================================
Files 34 34
Lines 3513 3513
=============================================
Hits 2592 2592
Misses 921 921 |
scpeters
changed the title
scpeters
approved these changes
Jun 10, 2023
scpeters
pushed a commit
that referenced
this pull request
Jun 10, 2023
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
|
back porting to ign-sensors3 in #353 |
46 tasks
scpeters
pushed a commit
that referenced
this pull request
Jun 12, 2023
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
scpeters
pushed a commit
that referenced
this pull request
Jun 13, 2023
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
GzProtobuf: Do not require version 3 do support Protobuf 4.23.2 (23.2)
Summary
The motivation is similar to gazebosim/gz-msgs#346 . For some reason in the case of this library there are no linking problem at build time, but rather runtime ABI issues: conda-forge/gz-sensors-feedstock#13 (comment) .
Test it
Install protobuf 23.2 and run the tests (I guess the only way to do it easily for now is to use conda-forge, see https://repology.org/project/protobuf/versions .
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.