Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of encoding #105

Open
melmothx opened this issue Oct 27, 2018 · 0 comments
Open

Handling of encoding #105

melmothx opened this issue Oct 27, 2018 · 0 comments

Comments

@melmothx
Copy link

melmothx commented Oct 27, 2018

It occurred to me that the lines returned by Git::Wrapper are octects, not characters. I understand that this is undertested, given that most of us write commit messages in English/ASCII only, however, looking at the source, it seems that no attempt to decode the strings is done.

This is not a bug per se, but I'd suggest to formalize this in the documentation, so people using the module are aware of what kind of strings to expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant