From e44adb45329b2d26449d681275413c61b77b8987 Mon Sep 17 00:00:00 2001
From: Olivia Guyot <olivia.guyot@camptocamp.com>
Date: Thu, 22 Feb 2024 10:52:00 +0100
Subject: [PATCH 1/4] type(dropdow-multiselect): fix typings

that cause issue when reusing/extending the components
---
 .../lib/filter-dropdown/filter-dropdown.component.ts | 12 ++++++------
 .../search/src/lib/utils/service/fields.service.ts   |  2 +-
 .../src/lib/autocomplete/autocomplete.component.html |  2 +-
 .../dropdown-multiselect.component.html              |  2 +-
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/libs/feature/search/src/lib/filter-dropdown/filter-dropdown.component.ts b/libs/feature/search/src/lib/filter-dropdown/filter-dropdown.component.ts
index 4406b373d..792e549ea 100644
--- a/libs/feature/search/src/lib/filter-dropdown/filter-dropdown.component.ts
+++ b/libs/feature/search/src/lib/filter-dropdown/filter-dropdown.component.ts
@@ -9,8 +9,8 @@ import { Observable, of, switchMap } from 'rxjs'
 import { catchError, filter, map, startWith } from 'rxjs/operators'
 import { SearchFacade } from '../state/search.facade'
 import { SearchService } from '../utils/service/search.service'
-import { FieldsService } from '../utils/service/fields.service'
-import { FieldAvailableValue } from '../utils/service/fields'
+import { FieldsService, FieldValues } from '../utils/service/fields.service'
+import { FieldAvailableValue, FieldValue } from '../utils/service/fields'
 
 @Component({
   selector: 'gn-ui-filter-dropdown',
@@ -29,13 +29,13 @@ export class FilterDropdownComponent implements OnInit {
     ),
     map((fieldValues) => fieldValues[this.fieldName]),
     filter((selected) => !!selected),
-    startWith([]),
-    catchError(() => of([]))
+    startWith([] as FieldValues[]),
+    catchError(() => of([] as FieldValues[]))
   )
 
-  onSelectedValues(values: (string | number)[]) {
+  onSelectedValues(values: unknown[]) {
     this.fieldsService
-      .buildFiltersFromFieldValues({ [this.fieldName]: values })
+      .buildFiltersFromFieldValues({ [this.fieldName]: values as FieldValue[] })
       .subscribe((filters) => this.searchService.updateFilters(filters))
   }
 
diff --git a/libs/feature/search/src/lib/utils/service/fields.service.ts b/libs/feature/search/src/lib/utils/service/fields.service.ts
index a99ddfa0d..075649394 100644
--- a/libs/feature/search/src/lib/utils/service/fields.service.ts
+++ b/libs/feature/search/src/lib/utils/service/fields.service.ts
@@ -17,7 +17,7 @@ import { FieldFilters } from '@geonetwork-ui/common/domain/model/search'
 import { marker } from '@biesbjerg/ngx-translate-extract-marker'
 
 // key is the field name
-export type FieldValues = Record<string, FieldValue[] | FieldValue>
+export type FieldValues = Record<string, FieldValue[]>
 
 marker('search.filters.format')
 marker('search.filters.inspireKeyword')
diff --git a/libs/ui/inputs/src/lib/autocomplete/autocomplete.component.html b/libs/ui/inputs/src/lib/autocomplete/autocomplete.component.html
index 227b9f17b..e542a23df 100644
--- a/libs/ui/inputs/src/lib/autocomplete/autocomplete.component.html
+++ b/libs/ui/inputs/src/lib/autocomplete/autocomplete.component.html
@@ -6,7 +6,7 @@
     [placeholder]="placeholder"
     [formControl]="control"
     [matAutocomplete]="auto"
-    (keyup.enter)="handleEnter($event.target.value)"
+    (keyup.enter)="handleEnter(searchInput.value)"
   />
   <button
     type="button"
diff --git a/libs/ui/inputs/src/lib/dropdown-multiselect/dropdown-multiselect.component.html b/libs/ui/inputs/src/lib/dropdown-multiselect/dropdown-multiselect.component.html
index 439d19737..fb14676c4 100644
--- a/libs/ui/inputs/src/lib/dropdown-multiselect/dropdown-multiselect.component.html
+++ b/libs/ui/inputs/src/lib/dropdown-multiselect/dropdown-multiselect.component.html
@@ -113,7 +113,7 @@
         type="checkbox"
         #checkBox
         [checked]="isSelected(choice)"
-        (change)="select(choice, $event.target.checked)"
+        (change)="select(choice, checkBox.checked)"
       />
       <span class="ml-[8px] text-[14px] truncate">
         {{ choice.label }}

From 9bfaa97b60b195f18987ee2ef4e63cb7eb0b0f5b Mon Sep 17 00:00:00 2001
From: Tobias Kohr <tobias.kohr@camptocamp.com>
Date: Thu, 22 Feb 2024 11:30:01 +0100
Subject: [PATCH 2/4] type(fields): keep FieldValue in FieldValues type

---
 .../src/lib/filter-dropdown/filter-dropdown.component.ts  | 8 ++++----
 .../search/src/lib/utils/service/fields.service.ts        | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/libs/feature/search/src/lib/filter-dropdown/filter-dropdown.component.ts b/libs/feature/search/src/lib/filter-dropdown/filter-dropdown.component.ts
index 792e549ea..8e36fb08b 100644
--- a/libs/feature/search/src/lib/filter-dropdown/filter-dropdown.component.ts
+++ b/libs/feature/search/src/lib/filter-dropdown/filter-dropdown.component.ts
@@ -9,7 +9,7 @@ import { Observable, of, switchMap } from 'rxjs'
 import { catchError, filter, map, startWith } from 'rxjs/operators'
 import { SearchFacade } from '../state/search.facade'
 import { SearchService } from '../utils/service/search.service'
-import { FieldsService, FieldValues } from '../utils/service/fields.service'
+import { FieldsService } from '../utils/service/fields.service'
 import { FieldAvailableValue, FieldValue } from '../utils/service/fields'
 
 @Component({
@@ -29,9 +29,9 @@ export class FilterDropdownComponent implements OnInit {
     ),
     map((fieldValues) => fieldValues[this.fieldName]),
     filter((selected) => !!selected),
-    startWith([] as FieldValues[]),
-    catchError(() => of([] as FieldValues[]))
-  )
+    startWith([]),
+    catchError(() => of([]))
+  ) as Observable<FieldValue[]>
 
   onSelectedValues(values: unknown[]) {
     this.fieldsService
diff --git a/libs/feature/search/src/lib/utils/service/fields.service.ts b/libs/feature/search/src/lib/utils/service/fields.service.ts
index 075649394..a99ddfa0d 100644
--- a/libs/feature/search/src/lib/utils/service/fields.service.ts
+++ b/libs/feature/search/src/lib/utils/service/fields.service.ts
@@ -17,7 +17,7 @@ import { FieldFilters } from '@geonetwork-ui/common/domain/model/search'
 import { marker } from '@biesbjerg/ngx-translate-extract-marker'
 
 // key is the field name
-export type FieldValues = Record<string, FieldValue[]>
+export type FieldValues = Record<string, FieldValue[] | FieldValue>
 
 marker('search.filters.format')
 marker('search.filters.inspireKeyword')

From 674b0fb5f7c0b0e27202e34b67942dd0ab20ef7e Mon Sep 17 00:00:00 2001
From: Tobias Kohr <tobias.kohr@camptocamp.com>
Date: Thu, 22 Feb 2024 11:39:46 +0100
Subject: [PATCH 3/4] fix(package): add missing export

to allow building npm package `node generate-package.js`
---
 libs/ui/inputs/src/index.ts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libs/ui/inputs/src/index.ts b/libs/ui/inputs/src/index.ts
index 4bda2ddfb..18bb63073 100644
--- a/libs/ui/inputs/src/index.ts
+++ b/libs/ui/inputs/src/index.ts
@@ -19,3 +19,4 @@ export * from './lib/viewport-intersector/viewport-intersector.component'
 export * from './lib/checkbox/checkbox.component'
 export * from './lib/search-input/search-input.component'
 export * from './lib/date-range-picker/date-range-picker.component'
+export * from './lib/editable-label/editable-label.directive'

From eee3946b41319ba008cc43f4663f1f9f58fdd93a Mon Sep 17 00:00:00 2001
From: Tobias Kohr <tobias.kohr@camptocamp.com>
Date: Thu, 22 Feb 2024 12:22:53 +0100
Subject: [PATCH 4/4] type(favorite-star): change record type to
 Partial<CatalogRecord>

---
 .../src/lib/favorites/favorite-star/favorite-star.component.ts  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libs/feature/search/src/lib/favorites/favorite-star/favorite-star.component.ts b/libs/feature/search/src/lib/favorites/favorite-star/favorite-star.component.ts
index 7dc7e6a6f..a6a9a1e8a 100644
--- a/libs/feature/search/src/lib/favorites/favorite-star/favorite-star.component.ts
+++ b/libs/feature/search/src/lib/favorites/favorite-star/favorite-star.component.ts
@@ -39,7 +39,7 @@ export class FavoriteStarComponent implements AfterViewInit, OnDestroy {
     map((favorites) => favorites.indexOf(this.record.uniqueIdentifier) > -1)
   )
   isAnonymous$ = this.platformService.isAnonymous()
-  record_: CatalogRecord
+  record_: Partial<CatalogRecord>
   favoriteCount: number | null
   loading = false
   loginUrl = this.authService.loginUrl