Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Use separate ref and dev lumped species definition files in benchmarking #81

Open
lizziel opened this issue May 7, 2020 · 6 comments
Labels
category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output

Comments

@lizziel
Copy link
Contributor

lizziel commented May 7, 2020

It would be nice to be able to compare lumped species before and after any changes in constituent species between versions during benchmarking. I propose that we do this by using the Ref version lumped species definition for Ref plots and the Dev version lumped species definition for Dev plots in benchmarks. This will allow side by side comparison of the concentrations without have to refer back to the last benchmark plots.

This could go along with an update to store the lumped species definitions within GEOS-Chem source code rather than GCPy so that it can be updated and tracked alongside chemistry changes. This would also help move towards decoupling GCPy and GEOS-Chem versions.

This update is best put into whatever GCPy version we use for 13.0 benchmark since that GEOS-Chem version will contain run directory files.

@lizziel lizziel added the category: Feature Request New feature or request label May 7, 2020
@lizziel lizziel self-assigned this May 7, 2020
@yantosca yantosca added the never stale Never label this issue as stale label Jan 13, 2021
@msulprizio msulprizio removed the never stale Never label this issue as stale label Mar 3, 2021
@yantosca
Copy link
Contributor

yantosca commented Aug 6, 2021

@lizziel @msulprizio has this been done in the latest benchmark? If so we can close it out.

@yantosca yantosca closed this as completed Aug 6, 2021
@yantosca yantosca reopened this Aug 6, 2021
@msulprizio
Copy link
Contributor

No, I don't believe this has been done

@lizziel lizziel removed their assignment Aug 24, 2021
@lizziel
Copy link
Contributor Author

lizziel commented Sep 27, 2022

I am revisiting this issue because we are discussing putting a path to the species database in the benchmark yml file. @yantosca, would it be much work (or even worthwhile) to have separate species databased for ref and dev? Maybe it would be more trouble than it is worth?

@lizziel
Copy link
Contributor Author

lizziel commented Sep 27, 2022

Actually, I just realized this issue is about lumped species, not the species database.

Copy link
Contributor

@lizziel, we could specify ref & dev species database or lumped_species. We'd need to add a lumped_species.yml to the run directories, though.

@yantosca yantosca added the topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output label Oct 6, 2022
@yantosca yantosca reopened this Nov 30, 2023
@geoschem geoschem deleted a comment from github-actions bot Dec 11, 2023
Copy link

github-actions bot commented Feb 9, 2024

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output
Projects
None yet
Development

No branches or pull requests

3 participants