Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urllib3 v2 breaks detection of http_client_requests in apps that use the "requests" package #239

Open
apotterri opened this issue May 9, 2023 · 0 comments
Open

urllib3 v2 breaks detection of http_client_requests in apps that use the "requests" package #239

apotterri opened this issue May 9, 2023 · 0 comments
Assignees
@apotterri
Labels
appmap-python enhancement New feature or request

Comments

@apotterri
Copy link
Collaborator

apotterri commented May 9, 2023 •
edited
Loading

The latest version of the widely-used requests package has changed to depend on v2 of urllib3. This breaks capturing of http_client_requests for apps that use it.

Pinning to v1 of urllib3 (as suggested in the requests doc) fixes this, but appmap-python should support both versions of urllib3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apotterri apotterri

Labels
appmap-python enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apotterri