Skip to content

Commit

Permalink
Remove Close from the signer implementations
Browse files Browse the repository at this point in the history
Signed-off-by: Kim Christensen <kimworking@gmail.com>
  • Loading branch information
kichristensen committed Apr 30, 2024
1 parent ddd49d0 commit 203f916
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
5 changes: 0 additions & 5 deletions pkg/signing/plugins/cosign/cosign.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,6 @@ func (s *Cosign) Connect(ctx context.Context) error {
return nil
}

// Close implements the Close method on the signing plugins' interface.
func (s *Cosign) Close() error {
return nil
}

func (s *Cosign) Sign(ctx context.Context, ref string) error {
//lint:ignore SA4006 ignore unused ctx for now
ctx, log := tracing.StartSpan(ctx)
Expand Down
5 changes: 0 additions & 5 deletions pkg/signing/plugins/notation/notation.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,6 @@ func (s *Signer) Connect(ctx context.Context) error {
return nil
}

// Close implements the Close method on the signing plugins' interface.
func (s *Signer) Close() error {
return nil
}

func (s *Signer) Sign(ctx context.Context, ref string) error {
//lint:ignore SA4006 ignore unused ctx for now
ctx, log := tracing.StartSpan(ctx)
Expand Down

0 comments on commit 203f916

Please sign in to comment.