From c9861cccbeb04df41b9f966cbed31d14c7ab811c Mon Sep 17 00:00:00 2001 From: Arpad Borsos Date: Wed, 3 Apr 2024 10:19:22 +0200 Subject: [PATCH] Fix `clippy` lints, and update CI actions (#87) --- .github/workflows/ci.yml | 8 ++++---- .github/workflows/release.yml | 2 +- .github/workflows/weekly.yml | 2 +- src/builder.rs | 1 - src/hermes.rs | 3 ++- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e164e60..84d42f4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,7 +15,7 @@ jobs: name: Lints runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - run: rustup toolchain install stable --profile minimal --component rustfmt --component clippy --no-self-update @@ -29,7 +29,7 @@ jobs: name: Unit Tests runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - run: rustup toolchain install stable --profile minimal --no-self-update @@ -41,7 +41,7 @@ jobs: name: "Unit Tests - all features" runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - run: rustup toolchain install stable --profile minimal --no-self-update @@ -55,7 +55,7 @@ jobs: env: RUSTDOCFLAGS: -Dwarnings steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - run: rustup toolchain install stable --profile minimal --component rust-docs --no-self-update diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 7bf197e..ee60c16 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -15,7 +15,7 @@ jobs: runs-on: ubuntu-latest name: "Release a new version" steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: token: ${{ secrets.GH_RELEASE_PAT }} fetch-depth: 0 diff --git a/.github/workflows/weekly.yml b/.github/workflows/weekly.yml index 69aa066..6fc0530 100644 --- a/.github/workflows/weekly.yml +++ b/.github/workflows/weekly.yml @@ -18,7 +18,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - run: | rustup toolchain install ${{ matrix.rust }} --profile minimal --component clippy --no-self-update diff --git a/src/builder.rs b/src/builder.rs index 3980ed6..8bb0cc6 100644 --- a/src/builder.rs +++ b/src/builder.rs @@ -1,6 +1,5 @@ #![cfg_attr(not(any(unix, windows, target_os = "redox")), allow(unused_imports))] -use std::convert::AsRef; use std::env; use std::fs; use std::io::Read; diff --git a/src/hermes.rs b/src/hermes.rs index 55cca4f..0bc99e9 100644 --- a/src/hermes.rs +++ b/src/hermes.rs @@ -55,7 +55,8 @@ impl Encodable for SourceMapHermes { fn as_raw_sourcemap(&self) -> RawSourceMap { // TODO: need to serialize the `HermesFunctionMap` mappings let mut rsm = self.sm.as_raw_sourcemap(); - rsm.x_facebook_sources = self.raw_facebook_sources.clone(); + rsm.x_facebook_sources + .clone_from(&self.raw_facebook_sources); rsm } }