General Thread (Q4 2021)

[chadwhitacre]

Trying out a little something here. This is a general thread for small questions and other more casual interaction that doesn't justify an entire ticket of its own. Scoping this to the quarter, let's see how it goes. :)

| Q1 2022 →

[chadwhitacre]

GitHub just released some updates including a new setting for code reviews:

Limit to users explicitly granted read or higher access
When enabled, only users explicitly granted access to this repository will be able to submit pull request reviews that "approve" or "request changes". All users able to submit comment pull request reviews will continue to be able to do so.

I just enabled this in the self-hosted repo, hopefully @aminvakil that means your approvals will count now (unlike on #1170)? :)

P.S. @BYK Do you want Triage role since you seem to still want to be at least occasionally active here?

[BYK]

P.S. @BYK Do you want Triage role since you seem to still want to be at least occasionally active here?

I mean, why not? 🙂

[BYK]

BRING US GITHUB DISCUSSIONS YOU COWARDS! 😝

[chadwhitacre]

I mean, why not? 🙂

Invite sent! 💃

BRING US GITHUB DISCUSSIONS YOU COWARDS! 😝

#1151 (comment) 😜

[chadwhitacre]

I reopened https://github.com/getsentry/self-hosted/milestone/5 because we should really address #1133 before closing. Anything else?

[patrakov]

I have a self-hosted installation of Sentry 21.9.0 (sorry for not updating it).

I know that some components of Sentry are written in Java. Today I have read the news about a critical log4j vulnerability (https://www.lunasec.io/docs/blog/log4j-zero-day/, CVE-2021-44228). Are Sentry installations using scripts from this repository affected? If so, what's the proper way to apply a fix or workaround?

[BYK]

@patrakov Sentry does not have any Java code in it. That said it uses Kafka and Zookeeper so it'd be better to look there. Self-hosted uses Confluent packages so you may check them and submit a PR to upgrade the packages if you see something.

[bryceadams]

Would also love confirmation on the vulernability as @patrakov mentioned, since it does look like some old log4j versions (1.x) were used when I searched a self-hosted server for log4j with sudo find / -iname '*log4j*.jar'. But I'm not very familiar with Docker/Kafka so wouldn't know where to check next. Thank you 😊

[aminvakil]

@patrakov @BYK @bryceadams I think it's better to continue this in #1196 ;)

[bergpb]

Hello everyone, recently I migrated from version 9.0 to version 21.5.
I would like to confirm that all issues/events were migrated correctly between versions, is there a way to confirm this information? Or at least return all issues/events per project, which I can check project by project.

[aminvakil]

Hello @bergpb
https://YOUR_SENTRY_INSTANCE/organizations/sentry/issues/ returns all issues for all projects
and
https://YOUR_SENTRY_INSTANCE/organizations/sentry/issues/?project=1 returns issue per project (project 1 is internal by default)

[bergpb]

Hello, everyone!!! After upgrading, some project issues were not imported, would this be expected behavior? I was careful to remove the service that auto removes the issues before updating Sentry with the new version. For example, a project that had more than 4000 issues, after the update only 562 are displayed. The information was checked using a python script where it searches for the issues through the Sentry API.

[chadwhitacre]

a project that had more than 4000 issues, after the update only 562 are displayed

Is it possible that some events are being grouped together now that previously were not?

[bergpb]

Great point @chadwhitacre, but is there any way to confirm this?

[BYK]

@bergpb I think this is more likely due to the newly set retention limit, which is 90 days (compared to infinite in the earlier versions)

[bergpb]

Hello @BYK , before upgrading the new version I paid attention to disabling this service as recommended in the documentation, for this, I just commented on the sentry-cleanup service in the compose file: https://github.com/getsentry/self-hosted#event-retention

[BYK]

@bergpb the service does regular cleaning but the environment variable is used by other services such as Sentry Web itself (especially during this migration) and Snuba too. And unfortunately setting that beyond 90 days is not supported in Snuba nor the UI supports wider ranges I think.

[bergpb]

@BYK, so even if you remove the service sentry-cleanup and also increase the value of the environment variable, will Sentry still remove older issues after migration?

[BYK]

and also increase the value of the environment variable, will Sentry still remove older issues after migration?

If you increase the value, it should respect that value.

[bergpb]

I will try to run the upgrade 9.0 -> 21.5 again, but now increasing the value, I will share the results here.

[chadwhitacre]

New year, new quarter, new thread! :)

#1239