Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SentryUser Swift name to something other than User #1100

Closed
Tracked by #1844
colinhumber opened this issue Apr 29, 2021 · 4 comments · Fixed by #2403
Closed
Tracked by #1844

Change SentryUser Swift name to something other than User #1100

colinhumber opened this issue Apr 29, 2021 · 4 comments · Fixed by #2403

Comments

@colinhumber
Copy link

The Obj-C SentryUser has a Swift name of User via NS_SWIFT_NAME(User). User is an incredibly common class name in apps, and having this renamed to User in Swift causes a lot more issues than it needs to. If I have a class that uses both Sentry and my own User class, I need to explicitly use MyModule.User in order to avoid naming conflicts.

I understand this would be a breaking change, but using the Sentry framework should provide as few roadblocks to using our own code as possible. Thanks!

@philipphofmann philipphofmann added this to the 8.0.0 milestone Apr 30, 2021
@philipphofmann
Copy link
Member

Ah, if you just opened up this issue a few days earlier 😁. We just shipped 7.0.0. I add this to 8.0.0, so we can discuss this in the next major. I agree with you that we should change this. Thanks for pointing it out.

@colinhumber
Copy link
Author

Awesome! Glad it's on the roadmap!

@philipphofmann
Copy link
Member

Maybe we could use a protocol and some subclassing to not make this a breaking change.

@philipphofmann
Copy link
Member

Closed with #2403.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants