-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASP.NET Core docs for performance don't mention requests are measured #8532
Comments
Correction: |
@bruno-garcia not regressed... updated to reflect this change in 3.40.0: |
Context about this change and side effects on Discord: https://discord.com/channels/621778831602221064/1175852280625500281/1175901670702600323 @jamescrosswell there's no reference of this at all on the docs: https://docs.sentry.io/platforms/dotnet/guides/aspnetcore/performance/ We could expand on this, for users coming back after using the middleware and new users, that wonder what setting the sample rate does |
Verify in the docs tells ppl to go to the Custom Transaction:
|
Do you mean like some docs saying that people no longer need to call |
Yeah we usually write stuff on a migration document (https://docs.sentry.io/platforms/dotnet/migration/) |
https://docs.sentry.io/platforms/dotnet/guides/aspnetcore/performance/
Missing the
UseSentryTracing
instructions.This way users will not get any transactions.
Must have regressed at some point
new project wizard in-product has the instructions:
With Sentry SDK for .NET version 4.0.0 we'll drop .NET 5 (6 will be the lowest) so worth updating that comment
The text was updated successfully, but these errors were encountered: