Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DiagnosticSource #1150

Closed
bruno-garcia opened this issue Aug 4, 2021 · 1 comment
Closed

Support for DiagnosticSource #1150

bruno-garcia opened this issue Aug 4, 2021 · 1 comment
Labels
Feature New feature or request Product: Tracing

Comments

@bruno-garcia
Copy link
Member

As discussed on a call while reviewing #1149:

  • Create a new package Sentry.Diagnostics.DiagnosticSource
  • New package will:
    • depends on System.Diagnostics.DiagnosticSource
    • target only ns2.0, ns2.1, net461 (newer targets already include S.D.D
  • Sentry package will include all ../Sentry.Diagnostics.DiagnosticSource/**/*.cs files when targeting nca3.0 or higher
  • Unit tests under S.D.D would also be included in Sentry.Tests
  • Packages that will depend on Sentry.Diagnostics.DiagnosticSource:
    • Sentry.AspNet
    • Sentry.Extensions.Logging when targeting ns2.0. #ifdef to enable the listeners on that TFM
  • Document the package, particularly:
    • This package is not needed when using Sentry with .NET Core 3 or higher.
    • This package is already brought in (you don't need to add) when using:
      • Sentry.Extensions.Logging
      • Sentry.AspNet
      • Sentry.AspNetCore
    • You can add this package to get:
      • Spans for queries executed with System.Data.SqlClient
      • ... (we can add HTTP requests too without the need of the HttpMessageHandler)
  • Helper method to add all listeners to be called by Sentry itself on nca3.0 or higher, or users of S.D.D by hand. Such as: SentrySdk.Init(o => o.AddDiagnosticListeners()
@bruno-garcia
Copy link
Member Author

Done through #1154.
Closing this as done. Some final touches like docs will be tracked through #1172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request Product: Tracing
Projects
None yet
Development

No branches or pull requests

1 participant