You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Yeah, probably it should have been called dotnet, but effectively it's the same for this purpose.
Though after reading the spec for stack traces, I believe we still need to let platform be set on a stack trace/frame so that we can override it if we bundle native SDKs in the future.
We were wrong about this. The platform name won't always be "csharp". With the new Android support, if an event is generated from the embedded Android SDK, its platform will be "java". This would be evident on events exposed in a BeforeSend delegate. We shouldn't obsolete the property or remove it, as that will erroneously change the platform from "java" to "csharp" when roundtripping.
The protocol should allow different values to match the use case Matt described. But I believe there's still no need for Platform on the Scope though. So we could remove it from the scope.
Problem Statement
SentryEvents get the Platform property already set in the internal Constructor
sentry-dotnet/src/Sentry/SentryEvent.cs
Line 205 in def6231
and the scope does not override it when it gets applied
sentry-dotnet/src/Sentry/Scope.cs
Line 363 in def6231
Does this mean setting the Platform when configuring the scope doesn't do anything?
Solution Brainstorm
We might as well remove the 'Platform' from the scope.
The text was updated successfully, but these errors were encountered: