Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default metrics #3020

Closed
2 tasks
jamescrosswell opened this issue Jan 9, 2024 · 7 comments
Closed
2 tasks

Add default metrics #3020

jamescrosswell opened this issue Jan 9, 2024 · 7 comments

Comments

@jamescrosswell
Copy link
Collaborator

jamescrosswell commented Jan 9, 2024

There are various metrics that have already been instrumented in .NET which users might be interested in sending to Sentry:

We'll likely resolve this issue in multiple Pull Requests:

@jamescrosswell jamescrosswell added this to the 4.0.0 milestone Jan 9, 2024
@bruno-garcia
Copy link
Member

bruno-garcia commented Jan 13, 2024

Furthermore, the Polly.Extensions package now provides seamless integration with IServiceCollection and facilitates the export of Polly’s telemetry events into .NET metrics.

https://devblogs.microsoft.com/dotnet/building-resilient-cloud-services-with-dotnet-8/

maybe something interesting to tap into

@jamescrosswell
Copy link
Collaborator Author

jamescrosswell commented Jan 16, 2024

See Built in Metrics

I think we can tap into these using the MeterListner API.

@bruno-garcia
Copy link
Member

Added FirstChanceException to the list (I recall we talked about it but I couldn't find a ticket)

@jamescrosswell
Copy link
Collaborator Author

Added FirstChanceException to the list (I recall we talked about it but I couldn't find a ticket)

Yeah I remember discussing it. Were we just thinking of a counter for that one (# of first chance exceptions)?

@optical
Copy link

optical commented Jul 22, 2024

I wanted to double check that sampling of Observable instruments (eg ObservableCounter) is on the radar for this? Just had a play with the experimental feature and noticed it wasn't reporting any of the observable instruments yet (MeterListener.RecordObservableInstruments is never invoked)

We are otherwise looking forward to trying out Metrics with Sentry

@bitsandfoxes
Copy link
Contributor

I wanted to double check that sampling of Observable instruments (eg ObservableCounter) is on the radar for this?

It is now!

@bitsandfoxes
Copy link
Contributor

Sorry, we won't address this.
Superseded by #3597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Archived in project
Development

No branches or pull requests

4 participants