Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make System.Diagnostics.Metrics available in net7.0 and earlier #3090

Closed
jamescrosswell opened this issue Jan 29, 2024 · 1 comment
Closed

Comments

@jamescrosswell
Copy link
Collaborator

We have already a package, that's only used for older frameworks:

https://github.com/getsentry/sentry-dotnet/tree/main/src/Sentry.DiagnosticSource#when-shouldnt-i-include-this-package

Sentry DiagnosticSource integration

  • Baked in on net6.0 and later at the moment

System DiagnosticsMetrics integration

  • Baked in on net8.0 and later at the moment

Assuming we can bump the System.Diagnostics.DiagnosticSource version from 4.5.0 to 8.0.0, I could a .src/Sentry.DiagnosticSource/Internal/DiagnosticsMetrics folder containing the Metrics integration... include that in the root project for net8.0 and later and then people could grab the Sentry.DiagnosticSource either if they wanted the DiagnosticSource integration for netstandard/netframework or if they wanted the Metrics integration for net6.0 or below.

I am wondering whether that might create a clash however. If someone was running net6.0 and added a reference to Sentry.DiagnosticSource so that they could use the metrics integration... presumably their Sentry.nupkg would already include everything from src/Sentry.DiagnosticSource/Internal/DiagnosticSource but now so would the Sentry.DiagnosticSource.nupkg that they referred to as well.

Seems like actually these would have to exist as separate packages then... So we'd need a new Sentry.DiagnosticSource.Metrics package that people could add if they're on net6.0 or below, and we just do the same trick for that that we've done already for Sentry.DiagnosticSource.

Originally posted by @jamescrosswell in #3052 (comment)

@bitsandfoxes bitsandfoxes changed the title Make System.Diagnostics.Metrics available in net7.0 and earlier Make System.Diagnostics.Metrics available in net7.0 and earlier Feb 29, 2024
@bitsandfoxes
Copy link
Contributor

Sorry, we won't address this
Superseded by #3597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants