Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Profiling Tests #3637

Open
bitsandfoxes opened this issue Sep 27, 2024 · 2 comments
Open

Flaky Profiling Tests #3637

bitsandfoxes opened this issue Sep 27, 2024 · 2 comments
Assignees
@vaind
Labels
Flaky Test A test fails intermittently, passes on retry. Productivity killer. Product: Profiling Testing

Comments

@bitsandfoxes
Copy link
Contributor

I'm skipping the test Profiler_ThrowingOnSessionStartup_DoesntBreakSentryInit here: https://github.com/getsentry/sentry-dotnet/pull/3635/files

We should re-enable it.
@jamescrosswell
Copy link
Collaborator

We should re-enable it.

I'm not sure we should, unless we can make it more reliable. It fails all the time and we just rerun the tests until it passes. What's the point in the test in that case?

@bitsandfoxes
Copy link
Contributor Author

Bad phrasing. You're correct. They should be made "not flaky". What's the point of flaky tests.

@bitsandfoxes bitsandfoxes added Testing Flaky Test A test fails intermittently, passes on retry. Productivity killer. Product: Profiling labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaind vaind

Labels
Flaky Test A test fails intermittently, passes on retry. Productivity killer. Product: Profiling Testing
Projects
.NET & Gaming
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jamescrosswell @vaind @bitsandfoxes