Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(replay): Streamline replay EventBuffer implementation #6416

Merged
merged 2 commits into from
Dec 6, 2022
Merged

ref(replay): Streamline replay EventBuffer implementation #6416

merged 2 commits into from
Dec 6, 2022

Commits on Dec 5, 2022

  1. ref(replay): Streamline replay EventBuffer implementation 

    This ensures public/private annotation is correct for the event buffer implementation. It also refactors a few (internal) things in minor ways, for clarity.

For example, we used a getter which as a side effect incremented itself. It is cleaner to do this explicitly, as getters should generally be side-effect free.
    @mydea
    mydea committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    45387c1 View commit details
    Browse the repository at this point in the history

  2. docs(replay): Add migration mention

    @mydea
    mydea committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    63b5433 View commit details
    Browse the repository at this point in the history