Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beforeBreadcrumb, withScope callbacks do not have their Exceptions caught #2499

Closed
Tracked by #21
krystofwoldrich opened this issue Sep 27, 2022 · 2 comments · Fixed by #2502
Closed
Tracked by #21

beforeBreadcrumb, withScope callbacks do not have their Exceptions caught #2499

krystofwoldrich opened this issue Sep 27, 2022 · 2 comments · Fixed by #2502

Comments

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Sep 27, 2022

this resolves in the app crashing

JS sdk doesn't solve this because the website doesn't crash like RN app does

List of callback:

  • beforeSend - safe from JS sdk
  • 
beforeBreadcrumb
 - not safe - JS sdk won't cahnge it (it doesn't crash a page)
  • withScope - not safe - JS sdk won't cahnge it (it doesn't crash a page)
  • 

onReady - not safe
  • integrations - not safe
  • initialScope - deprecated not safe

What should we do with:

  • transport - note safe -> create default?
  • tracesSampler
 - not safe -> default to 0?
@marandaneto
Copy link
Contributor

@krystofwoldrich I suspect that we've missed one of them:

configureScope:

                Sentry.configureScope((scope: Scope) => {
                  ...
                });

Or is it safe? I guess not.

@krystofwoldrich
Copy link
Member Author

@marandaneto Yes, we missed this one. I'll add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants