From c796a59aefc21fd5c38f8f0910a64eaf399b93fa Mon Sep 17 00:00:00 2001 From: Ryan Albrecht Date: Fri, 8 Dec 2023 09:44:13 -0800 Subject: [PATCH] feat(feedback): Urls to feedbacks should include the project that the feedback is part of (#61169) Fixes https://github.com/getsentry/team-replay/issues/290 --- src/sentry/models/group.py | 2 ++ tests/sentry/models/test_group.py | 4 +--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/sentry/models/group.py b/src/sentry/models/group.py index 61b308abefb651..a3780ae347e443 100644 --- a/src/sentry/models/group.py +++ b/src/sentry/models/group.py @@ -602,9 +602,11 @@ def get_absolute_url( if self.issue_category == GroupCategory.FEEDBACK: path = f"/organizations/{organization.slug}/feedback/" slug = {"feedbackSlug": f"{self.project.slug}:{self.id}"} + project = {"project": self.project.id} params = { **(params or {}), **slug, + **project, } query = urlencode(params) return organization.absolute_url(path, query=query) diff --git a/tests/sentry/models/test_group.py b/tests/sentry/models/test_group.py index 5b16e274ff7543..8d04c90b1e130b 100644 --- a/tests/sentry/models/test_group.py +++ b/tests/sentry/models/test_group.py @@ -242,9 +242,7 @@ def test_get_absolute_url_feedback(self): project = self.create_project(organization=org) group_id = 23 params = None - expected = ( - f"http://testserver/organizations/org1/feedback/?feedbackSlug={project.slug}%3A23" - ) + expected = f"http://testserver/organizations/org1/feedback/?feedbackSlug={project.slug}%3A23&project={project.id}" group = self.create_group(id=group_id, project=project, type=FeedbackGroup.type_id) actual = group.get_absolute_url(params)