not checking for errors?

[giampaolo]

From james....@gmail.com on July 17, 2012 11:04:45

Some of the code I'm looking at in _psutil_bsd.c isn't doing error checking at 
all. MemoryError's can happen.

Original issue: http://code.google.com/p/psutil/issues/detail?id=306

[giampaolo]

From g.rodola on July 17, 2012 02:08:01

Please provide a patch or tell where exactly the error checking is missing, 
otherwise it doesn't help. =)

[giampaolo]

From james....@gmail.com on July 17, 2012 02:11:06

=)

get_system_users function in _psutil_bsd.c

[giampaolo]

From g.rodola on July 17, 2012 02:23:21

Ok... but *WHERE*? fread()? And what change are you proposing?

[giampaolo]

From james....@gmail.com on July 17, 2012 02:27:23

Pretty much anywhere you allocate a Python object, it can return NULL. The code 
assumes that it doesn't...apparently everywhere.

In low memory situations, this has a pretty good chance of segfaulting out.

[giampaolo]

From g.rodola on July 17, 2012 02:57:47

I see now. You're right.

Status: Accepted
Labels: Milestone-1.0.0

[giampaolo]

From g.rodola on July 19, 2012 01:52:55

I consider this one fixed as of r1458 , r1459 , r1460 and r1463 .

Status: FixedInSVN

[giampaolo]

From g.rodola on August 13, 2012 09:25:14

Fixed in version 0.6.0, released just now.

Status: Fixed
Labels: -Milestone-1.0.0 Milestone-0.6.0

[giampaolo]

From g.rodola on March 02, 2013 04:11:17

Updated csets after the SVN -> Mercurial migration: r1458 == revision 
676085a259ed