500 Internal server error when visiting link for Pro Git v1 book

[HonkingGoose]

URL for broken page

https://git-scm.com/book/en/v1

Problem

The page linked above leads to a 500 Internal Server Error.

Operating system and browser

macOS 13, Firefox 113.0.1

Steps to reproduce

1. Go to https://git-scm.com/book/en/v1
2. End up at Internal server error page

Other details

The Pro Git book is on version 2 now. We should probably redirect to the landing page for the v2 book.

Related issue (filed in the wrong place):

• Redirect incoming request for https://git-scm.com/book/en/v1 to https://git-scm.com/book/en/v2 progit/progit2#1836

[pedrorijo91]

hey @HonkingGoose @derberg,

can you share where did you find links to book v1?

either way, it seems reasonable to redirect to some page. probably we removed the routing because v1 is really old AFAIK (i see v2 was released around 2014)

[HonkingGoose]

According to the first issue there are links pointing to the v1 version of the book in the GitHub Docs. I will open a PR in the GitHub Docs repo to fix the links.

[HonkingGoose]

I tried making the changes to the GitHub Docs myself, but I'm not allowed to touch the files with the bad links in it. So I'm opening an issue with GitHub Docs, so one of their maintainers can fix it. 😄

[HonkingGoose]

either way, it seems reasonable to redirect to some page. probably we removed the routing because v1 is really old AFAIK (i see v2 was released around 2014)

I'll let you guys decide. Possible fixes:

1. Do nothing, let downstream projects update their own links to broken pages
2. Redirect v1 to v2 in-place: only change v1 to v2 in the link
3. Redirect v1 links to a generic "homepage" for the v2 version of the book

[dscho]

For the record: after #1804 was merged, the link no longer 500s but 404s instead.

[LemmingAvalanche]

Related: I found this link which doesn’t say anything about the edition:

https://git-scm.com/book/en/Git-Tools-Rewriting-History

But this works:

https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

The second edition.

Maybe the first link could try to redirect to /v2?

[dscho]

@LemmingAvalanche good idea! We should automate this by patching in aliases here (both v1.html and v1/index.html), and here (being careful to special-case %3F, i.e. the question mark, also for the v1 redirect).

@LemmingAvalanche want to give it a try?

[LemmingAvalanche]

@dscho Sure thing, I can look at this this evening.

I’ll reply later if it turns out that it needs someone more experienced.