Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supress validation for a line/file #123

Open
jasperfirecai2 opened this issue Apr 17, 2023 · 5 comments
Open

Supress validation for a line/file #123

jasperfirecai2 opened this issue Apr 17, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@jasperfirecai2
Copy link

jasperfirecai2 commented Apr 17, 2023

Is your feature request related to a problem? Please describe.
On some workflows, the linter will mark things as potential issues because of the way it was written. however, as a writer you have additional information and can possibly conclude that there is no problem. In that situation, having a linter warning is mildly annoying.

For example, I have a workflow that dynamically gets the name of a secret and the accesses secrets[that value]. Linter tell me that the context access might be invalid. this is correct, but I know that the only possible values should be valid or I've done something wrong elsewhere.

Describe the solution you'd like
I'd like to have something along the lines of #pylint: disable etc. for this extension, whether it be a comment ( similar to pylint or eslint ), a config file (e.g. for file x ignore y), an extension setting (ignore warnings of type/ ignore files). To suppress warnings that you know are invalid, to help reduce false positives for issues that the extension simply lacks context for, or to purge warnings that come from bugs of third party workflow authors.

Additional context
related: #59

@felipesu19
Copy link
Collaborator

#196

@CaBazaga
Copy link

#196

Not the same, although related to same root problem (Underided problems being reported)
it's a diametrically opposed solution covering a very different scenario.

Extended comment there about the difference.

TLDR:

This is about "Configure your code". (Which has its use cases)
The other (#196) is about "configure the linter". (Which covers a very different use cases)

@jasperfirecai2
Copy link
Author

While my use case is not the same as that of the other issue, the solution to both can be one and the same. A comment can be file-wide and a config file can be file or project wide. Read the 'describe the solution you'd like'

@CaBazaga
Copy link

While my use case is not the same as that of the other issue, the solution to both can be one and the same. A comment can be file-wide and a config file can be file or project wide. Read the 'describe the solution you'd like'

You're right, my fault was reading the title... 😉

@cringdahl
Copy link

This would be especially useful for something like octokit/request-action, which takes arbitrary input keys, but kicks out errors for every one of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Triaged 📝
Development

No branches or pull requests

4 participants