Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong constructor properties for GLib.Error #179

Open
JumpLink opened this issue Jul 21, 2024 · 0 comments
Open

Wrong constructor properties for GLib.Error #179

JumpLink opened this issue Jul 21, 2024 · 0 comments
Assignees
Labels
bug gjs-convention Marks issues for aligning with GJS coding standards and practices

Comments

@JumpLink
Copy link
Collaborator

Currently the Error constructor is generated like this:

class Error {
    constructor(
        properties?: Partial<{
            domain: Quark;
            code: number;
            message: string;
        }>,
    );
}

But it should look like this:

class Error {
    constructor(domain: Quark, code: number, message: string);
}

@ewlsh This is generated in the ModuleGenerator.generateDirectAllocationConstructor, but I am not sure if this should be changed for all, or is both possible or there is a special case here. Do you know more about this?

@JumpLink JumpLink added bug gjs-convention Marks issues for aligning with GJS coding standards and practices labels Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug gjs-convention Marks issues for aligning with GJS coding standards and practices
Projects
None yet
Development

No branches or pull requests

2 participants