-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some suggestions #25
Comments
Hi, a general quick win: You can style the display position and color of the banner by adding your styling to your local userstyle.css. Hiding the approve message for r/o users and shortening it is basically (but fix, non-editable) implemented in https://github.com/mdiedrich-rz/dokuwiki-plugin-approve/tree/display_banner (not reviewed yet, my personal development). Comments are appreciated. Approving all pending changes at once could be a good idea - in my opinion approving a page means viewing it, reading it, understanding it, thinking about it and then approving it (or not ;)). So batch processing isn't possible in that process and so normally not needed (perhaps for the first time after enabling the approve plugin). My approvement - my responsibility - my job to really review the changes. A question of processes to be defined :). I'd just like to add another suggestion:
Bye and thanks for your suggestions :). |
The time based notifications was implemented by my as watchcycle plugin some time ago. But it would be better if this feature is integrated into approve directly.
Do you want to approve all pages without viewing the changes between revisions? |
Thanks for your answers, About "adding your styling to your local userstyle.css.": I tried to mantain dokuwiki "as standard as possible" to avoid problems with future updates. But is an alternative, thanks. About "approve all pages": some scenarios where I think that this option would be useful:
Publish plugin has an option for this, we use it from time to time. |
Sounds reasonable. I believe we should include it in future releases. |
Hi,
¡Thank you for develop this plugin!. I've been using the Publish plugin until now, but I think that the Approve plugin has some advantages over Publish.
Some things I miss:
Bye!
The text was updated successfully, but these errors were encountered: