From a0d15f44a3d80962cdab3f5fe4983e3dd5b33650 Mon Sep 17 00:00:00 2001 From: mayank-96 Date: Tue, 25 Jul 2023 19:06:34 +0530 Subject: [PATCH 01/10] v0.1.17-alpha.1 --- packages/modal/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/modal/package.json b/packages/modal/package.json index 137122c1ff..298505a5ee 100644 --- a/packages/modal/package.json +++ b/packages/modal/package.json @@ -15,7 +15,7 @@ "ios", "nextjs" ], - "version": "0.1.16", + "version": "0.1.17-alpha.1", "main": "lib/commonjs/index", "module": "lib/module/index", "types": "lib/typescript/index.d.ts", From 6a7b5060e5c7bea1edc1d26a1cd10830f6fc4741 Mon Sep 17 00:00:00 2001 From: mayank-96 Date: Tue, 25 Jul 2023 19:39:33 +0530 Subject: [PATCH 02/10] v0.1.12-alpha.0 --- packages/alert-dialog/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/alert-dialog/package.json b/packages/alert-dialog/package.json index 0a38d438e3..61c8ee55df 100644 --- a/packages/alert-dialog/package.json +++ b/packages/alert-dialog/package.json @@ -15,7 +15,7 @@ "ios", "nextjs" ], - "version": "0.1.11", + "version": "0.1.12-alpha.0", "main": "lib/commonjs/index", "module": "lib/module/index", "types": "lib/typescript/index.d.ts", From 48faca69eb88a86736e2f299464afb397998aa83 Mon Sep 17 00:00:00 2001 From: mayank-96 Date: Tue, 25 Jul 2023 19:40:39 +0530 Subject: [PATCH 03/10] v0.2.14-alpha.0 --- packages/menu/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/menu/package.json b/packages/menu/package.json index 2e1f6ef7a7..c423f706cd 100644 --- a/packages/menu/package.json +++ b/packages/menu/package.json @@ -15,7 +15,7 @@ "ios", "nextjs" ], - "version": "0.2.13", + "version": "0.2.14-alpha.0", "main": "lib/commonjs/index", "module": "lib/module/index", "types": "lib/typescript/index.d.ts", From c8575e83af409c69b81218c11268faa839ed832f Mon Sep 17 00:00:00 2001 From: mayank-96 Date: Tue, 25 Jul 2023 19:41:22 +0530 Subject: [PATCH 04/10] v0.1.17-alpha.0 --- packages/popover/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/popover/package.json b/packages/popover/package.json index 0bcb03a4eb..e3f37344e6 100644 --- a/packages/popover/package.json +++ b/packages/popover/package.json @@ -1,6 +1,6 @@ { "name": "@gluestack-ui/popover", - "version": "0.1.16", + "version": "0.1.17-alpha.0", "main": "lib/commonjs/index", "module": "lib/module/index", "types": "lib/typescript/index.d.ts", From 1aedc5ea25f60d142b8985a7a6ffa3f746d473fa Mon Sep 17 00:00:00 2001 From: mayank-96 Date: Tue, 25 Jul 2023 19:42:12 +0530 Subject: [PATCH 05/10] v0.1.13-alpha.0 --- packages/tooltip/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/tooltip/package.json b/packages/tooltip/package.json index 274762578d..97f0684cbf 100644 --- a/packages/tooltip/package.json +++ b/packages/tooltip/package.json @@ -1,7 +1,7 @@ { "name": "@gluestack-ui/tooltip", "description": "A universal headless tooltip component for React Native, Next.js & React", - "version": "0.1.12", + "version": "0.1.13-alpha.0", "main": "lib/commonjs/index", "module": "lib/module/index", "types": "lib/typescript/index.d.ts", From 00a72cb432762d546ac3337a23cef5547a7d626c Mon Sep 17 00:00:00 2001 From: mayank-96 Date: Wed, 26 Jul 2023 12:31:41 +0530 Subject: [PATCH 06/10] v0.2.14-alpha.1 --- packages/menu/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/menu/package.json b/packages/menu/package.json index c423f706cd..790a41951f 100644 --- a/packages/menu/package.json +++ b/packages/menu/package.json @@ -15,7 +15,7 @@ "ios", "nextjs" ], - "version": "0.2.14-alpha.0", + "version": "0.2.14-alpha.1", "main": "lib/commonjs/index", "module": "lib/module/index", "types": "lib/typescript/index.d.ts", From c7401da80427c68b165069d8bf5620f324d1d78b Mon Sep 17 00:00:00 2001 From: mayank-96 Date: Wed, 26 Jul 2023 12:32:30 +0530 Subject: [PATCH 07/10] v0.2.13-alpha.0 --- packages/actionsheet/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/actionsheet/package.json b/packages/actionsheet/package.json index 3624e78eaa..07555fdec6 100644 --- a/packages/actionsheet/package.json +++ b/packages/actionsheet/package.json @@ -15,7 +15,7 @@ "ios", "nextjs" ], - "version": "0.2.12", + "version": "0.2.13-alpha.0", "main": "lib/commonjs/index", "module": "lib/module/index", "types": "lib/typescript/index.d.ts", From e13723bbc8775cad469bed6027e0c45ba05b8401 Mon Sep 17 00:00:00 2001 From: mayank-96 Date: Wed, 26 Jul 2023 13:26:45 +0530 Subject: [PATCH 08/10] v0.2.14-alpha.2 --- packages/menu/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/menu/package.json b/packages/menu/package.json index 790a41951f..a80f8ddd55 100644 --- a/packages/menu/package.json +++ b/packages/menu/package.json @@ -15,7 +15,7 @@ "ios", "nextjs" ], - "version": "0.2.14-alpha.1", + "version": "0.2.14-alpha.2", "main": "lib/commonjs/index", "module": "lib/module/index", "types": "lib/typescript/index.d.ts", From a0dd847f2997991b85bf89cf52f5c7c91c71b16a Mon Sep 17 00:00:00 2001 From: mayank-96 Date: Wed, 26 Jul 2023 13:27:51 +0530 Subject: [PATCH 09/10] fix: experimental overlay --- packages/actionsheet/src/Actionsheet.tsx | 16 ++++++ packages/alert-dialog/src/AlertDialog.tsx | 13 +++++ packages/menu/src/Menu.tsx | 22 ++++++++ packages/menu/src/MenuPopover/Popover.tsx | 51 +++++++++++++++++++ packages/menu/src/MenuPopover/Popover.web.tsx | 16 +++++- packages/modal/src/Modal.tsx | 12 +++++ packages/popover/src/Popover.tsx | 15 ++++++ packages/tooltip/src/Tooltip.tsx | 34 +++++++++++++ 8 files changed, 178 insertions(+), 1 deletion(-) diff --git a/packages/actionsheet/src/Actionsheet.tsx b/packages/actionsheet/src/Actionsheet.tsx index c68647815a..8173933832 100644 --- a/packages/actionsheet/src/Actionsheet.tsx +++ b/packages/actionsheet/src/Actionsheet.tsx @@ -22,6 +22,8 @@ export function Actionsheet(StyledActionsheet: React.ComponentType) { initialFocusRef, finalFocusRef, unmountOnExit = true, + // @ts-ignore + _experimentalOverlay = true, ...props }: T & IActionsheetProps, ref?: any @@ -73,6 +75,20 @@ export function Actionsheet(StyledActionsheet: React.ComponentType) { finalFocusRef, ]); + if (!_experimentalOverlay) { + return ( + + + {children} + + + ); + } + return ( (StyledAlertDialog: React.ComponentType) => isKeyboardDismissable = true, animationPreset = 'fade', unmountOnExit = true, + // @ts-ignore + _experimentalOverlay = true, ...props }: T & IAlertDialogProps, ref?: any @@ -72,6 +74,17 @@ export const AlertDialog = (StyledAlertDialog: React.ComponentType) => visible, ]); + if (!_experimentalOverlay) { + return ( + + + {children} + {avoidKeyboard ? avoidKeyboardSpacer : null} + + + ); + } + return ( + {updatedTrigger()} + + state.close()} + StyledMenu={StyledMenu} + StyledMenuItem={StyledMenuItem} + closeOnSelect={closeOnSelect} + ref={ref} + /> + + ); + } + return ( {updatedTrigger()} diff --git a/packages/menu/src/MenuPopover/Popover.tsx b/packages/menu/src/MenuPopover/Popover.tsx index dfc818c74e..8a013cacf0 100644 --- a/packages/menu/src/MenuPopover/Popover.tsx +++ b/packages/menu/src/MenuPopover/Popover.tsx @@ -27,6 +27,8 @@ export const Popover = forwardRef( shouldFlip, focusScope = true, StyledBackdrop, + // @ts-ignore + _experimentalOverlay = true, ...props }: any, ref: any @@ -82,6 +84,55 @@ export const Popover = forwardRef( const targetRefTemp = React.useRef(null); const targetRef = triggerRef || targetRefTemp; + + if (!_experimentalOverlay) { + return ( + <> + {updatedTrigger(targetRef)} + + + + + + {children} + + + + + + ); + } return ( <> {updatedTrigger(targetRef)} diff --git a/packages/menu/src/MenuPopover/Popover.web.tsx b/packages/menu/src/MenuPopover/Popover.web.tsx index 0c8169d46a..0758a76b86 100644 --- a/packages/menu/src/MenuPopover/Popover.web.tsx +++ b/packages/menu/src/MenuPopover/Popover.web.tsx @@ -2,7 +2,11 @@ import React from 'react'; import { View } from 'react-native'; import { usePopover, DismissButton, Overlay } from '@react-aria/overlays'; import { MenuContext } from '../MenuContext'; -export function Popover({ StyledBackdrop, ...props }: any) { +export function Popover({ + StyledBackdrop, // @ts-ignore + _experimentalOverlay = true, + ...props +}: any) { const ref = React.useRef(null); const { state, children } = props; const { onClose } = React.useContext(MenuContext); @@ -19,6 +23,16 @@ export function Popover({ StyledBackdrop, ...props }: any) { return null; } + if (!_experimentalOverlay) { + return ( + // @ts-ignore + + + {children} + + + ); + } return ( closeOnOverlayClick = true, isKeyboardDismissable = true, unmountOnExit = true, + _experimentalOverlay = true, ...props }: any, ref?: any @@ -72,6 +73,17 @@ const Modal = (StyledModal: any) => visible, ]); + if (!_experimentalOverlay) { + return ( + + + {children} + {avoidKeyboard ? avoidKeyboardSpacer : null} + + + ); + } + return ( offset, isKeyboardDismissable = true, shouldFlip, + // @ts-ignore + _experimentalOverlay = true, ...props }: any, ref?: any @@ -125,6 +127,19 @@ export const Popover = (StyledPopover: any) => shouldFlip, ]); + if (!_experimentalOverlay) { + return ( + <> + {updatedTrigger(targetRef)} + + + {children} + + + + ); + } + return ( <> {updatedTrigger(targetRef)} diff --git a/packages/tooltip/src/Tooltip.tsx b/packages/tooltip/src/Tooltip.tsx index 394809ed73..603996e3b7 100644 --- a/packages/tooltip/src/Tooltip.tsx +++ b/packages/tooltip/src/Tooltip.tsx @@ -29,6 +29,8 @@ function Tooltip( offset = 10, shouldOverlapWithTrigger = false, shouldFlip = true, + // @ts-ignore + _experimentalOverlay = true, ...props }: ITooltipProps, ref?: any @@ -119,6 +121,38 @@ function Tooltip( callback: () => setIsOpen(false), }); + if (!_experimentalOverlay) { + return ( + <> + {updatedTrigger(targetRef)} + + + {children} + + + + ); + } + return ( <> {updatedTrigger(targetRef)} From 997b0d64e19000fdfe9b426e56da967386094d5b Mon Sep 17 00:00:00 2001 From: Meenu Makkar Date: Wed, 26 Jul 2023 13:42:47 +0530 Subject: [PATCH 10/10] chore: version upgraded --- .changeset/cool-humans-reflect.md | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 .changeset/cool-humans-reflect.md diff --git a/.changeset/cool-humans-reflect.md b/.changeset/cool-humans-reflect.md new file mode 100644 index 0000000000..880f3b40a6 --- /dev/null +++ b/.changeset/cool-humans-reflect.md @@ -0,0 +1,10 @@ +--- +'@gluestack-ui/alert-dialog': patch +'@gluestack-ui/actionsheet': patch +'@gluestack-ui/popover': patch +'@gluestack-ui/tooltip': patch +'@gluestack-ui/modal': patch +'@gluestack-ui/menu': patch +--- + +Added experimentalOverlay flag for internal usecase