Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring inlay hints out of "proposal" feature #251

Closed
kaleidawave opened this issue Oct 21, 2022 · 1 comment · Fixed by #255
Closed

Bring inlay hints out of "proposal" feature #251

kaleidawave opened this issue Oct 21, 2022 · 1 comment · Fixed by #255

Comments

@kaleidawave
Copy link

Looks like the inlay hints have been standardized of 3.17.0 https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#version_3_17_0

Could these cfg guards now be removed?

lsp-types/src/lib.rs

Lines 147 to 150 in 9e6b353

#[cfg(feature = "proposed")]
mod inlay_hint;
#[cfg(feature = "proposed")]
pub use inlay_hint::*;

Haven't looked into whether any other guards need to be removed?

@ebkalderon
Copy link
Contributor

I've done precisely this in #255 along with other 3.17.0 features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants