Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support inline values? #252

Closed
OceanBelongsToMe opened this issue Nov 15, 2022 · 6 comments · Fixed by #255
Closed

support inline values? #252

OceanBelongsToMe opened this issue Nov 15, 2022 · 6 comments · Fixed by #255

Comments

@OceanBelongsToMe
Copy link

No description provided.

@Marwes
Copy link
Member

Marwes commented Dec 19, 2022

I have no idea what this means. Feel free to reopoen with more context

@Marwes Marwes closed this as completed Dec 19, 2022
This was referenced Jan 19, 2023
Closed
Merged
@ebkalderon
Copy link
Contributor

ebkalderon commented Jan 19, 2023 •
edited
Loading

I assume the title refers to the inline values feature included in LSP spec version 3.17.0. I've added support for this in #255.

@tooltitude-support
Copy link
Contributor

It looks like the type in this library is different from what's in the spec. The implementation has Option and the spec has InlineValue[] | null (see the link from the previous comment). Is it possible to change it?

@Veykril
Copy link

Veykril commented Dec 8, 2023

Ye that seems wrong, would be good to open a separate issue about that / a PR fixing it.

@tooltitude-support
Copy link
Contributor

@Veykril Sure! Will create a PR shortly.

@tooltitude-support
Copy link
Contributor

@Veykril Here it is: #272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support all new 3.17 features (except for notebooks) ebkalderon/lsp-types
5 participants
@ebkalderon @Marwes @Veykril @OceanBelongsToMe @tooltitude-support