From a0b787c39a7eab88c2de3a64aa872779b94abe39 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mike=20C=C3=B4t=C3=A9?=
-
-
-
-
- Please return to your
+ Configure monitoring through
+
+ Elasticsearch Service Console
+
+
+ (opens in a new tab or window)
+
+
+ Go to
- cloud dashboard.
+ Logs and metrics
- For more information on Monitoring in Elastic Cloud, please see
+ section for a deployment to configure monitoring. For more information visit
- the documentation.
+ the documentation page.
+
+
- Please return to your
+ Configure monitoring through
+
+ Elasticsearch Service Console
+
+
+ (opens in a new tab or window)
+
+
+ Go to
- cloud dashboard.
+ Logs and metrics
- For more information on Monitoring in Elastic Cloud, please see
+ section for a deployment to configure monitoring. For more information visit
- the documentation.
+ the documentation page.
Date: Fri, 15 Jan 2021 11:45:04 -0700
Subject: [PATCH 18/33] Change DELETE to POST for _bulk_delete to avoid
incompatibility issues (#87914)
## Summary
Changes `DELETE` to `POST` for _bulk_delete on the client only for a variety of reasons.
According to the RFC, not all servers and proxies need to honor DELETE having a body. From: https://tools.ietf.org/html/rfc7231
```
A payload within a DELETE request message has no defined semantics;
sending a payload body on a DELETE request might cause some existing
implementations to reject the request.
```
Within at least one proxy, h2o2, we have found that it does indeed change request headers which will cause NodeJS to not attach the body of a `DELETE`:
https://github.com/hapijs/h2o2/issues/124
Also from other communities such as OpenAPI where they debated this, they allow it but discourage it for reasons outlined there that I will not repeat here:
https://github.com/OAI/OpenAPI-Specification/pull/1937
Elastic Search API's and other Kibana API's use `POST` rather than `DELETE` for their bodies that are attached to `DELETE`:
https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-delete-by-query.html
We still support bodies in `DELETE` and `POST` but are just changing the web client to utilize `POST` moving forward.
### Checklist
Reviewed and we already have unit tests and end to end tests for these use cases so we are good with just updating them.
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
---
.../detections/containers/detection_engine/rules/api.test.ts | 2 +-
.../public/detections/containers/detection_engine/rules/api.ts | 2 +-
.../server/lib/detection_engine/scripts/delete_bulk.sh | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/x-pack/plugins/security_solution/public/detections/containers/detection_engine/rules/api.test.ts b/x-pack/plugins/security_solution/public/detections/containers/detection_engine/rules/api.test.ts
index e94cc8845c5a58..fce9974b458c5c 100644
--- a/x-pack/plugins/security_solution/public/detections/containers/detection_engine/rules/api.test.ts
+++ b/x-pack/plugins/security_solution/public/detections/containers/detection_engine/rules/api.test.ts
@@ -377,7 +377,7 @@ describe('Detections Rules API', () => {
await deleteRules({ ids: ['mySuperRuleId', 'mySuperRuleId_II'] });
expect(fetchMock).toHaveBeenCalledWith('/api/detection_engine/rules/_bulk_delete', {
body: '[{"id":"mySuperRuleId"},{"id":"mySuperRuleId_II"}]',
- method: 'DELETE',
+ method: 'POST',
});
});
diff --git a/x-pack/plugins/security_solution/public/detections/containers/detection_engine/rules/api.ts b/x-pack/plugins/security_solution/public/detections/containers/detection_engine/rules/api.ts
index a5dddd6d9afd39..da33b7841c7a90 100644
--- a/x-pack/plugins/security_solution/public/detections/containers/detection_engine/rules/api.ts
+++ b/x-pack/plugins/security_solution/public/detections/containers/detection_engine/rules/api.ts
@@ -205,7 +205,7 @@ export const enableRules = async ({ ids, enabled }: EnableRulesProps): Promise =>
KibanaServices.get().http.fetch {SAVE_CUSTOM_API_KEYS_BODY}
- Select from the content sources below to create a private source, available only to
- you
-
- Your organization's license level changed and no longer supports document-level
- permissions.{' '}
+ Your organization’s license level has changed. Your data is safe, but document-level
+ permissions are no longer supported and searching of this source has been disabled.
+ Upgrade to a Platinum license to re-enable this source.
Don't worry: your data is safe. Search has been disabled. Upgrade to a Platinum license to re-enable this source.
From c66c9424d9109e6de2406786a2ec2b9921a98244 Mon Sep 17 00:00:00 2001
From: Nathan Reese tW)Jo`UhGZWa|TGR3SNyr;=ZDWSRK=2`5A>ij5z|
zkumpw&eU(uTF{sDvO5kxax3!9M&bD$h(P7e^)8E{mUxkwKbX8#wx>($k^bl&T-I;P
zyJi}2$!*s;op
+
+
+
+
- Your monitoring data is not available here.
-
,
-
Content summary
- Content summary
+ b|GBU_hO;xb
zHm5a*&&)o}PU~z0Yl}9zsVTj{>00hy3zQmjF?!MI)|b5IF2V=mJ$D_=PnjTVz@Bor
z7o;#%