From e4d7528b26a64e392b799325535fb7dcd267a9a5 Mon Sep 17 00:00:00 2001 From: Morgan Date: Thu, 3 Oct 2024 11:30:16 +0200 Subject: [PATCH] ci: change alert-threshold to 120% (#2880) Apologies for the whitespace changes; if you disable them, you'll see it's a one-line change. See [alert threshold](https://github.com/benchmark-action/github-action-benchmark?tab=readme-ov-file#alert-threshold-optional) on the documentation of the action.
Contributors' checklist... - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
--- .github/workflows/benchmark-master-push.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/benchmark-master-push.yml b/.github/workflows/benchmark-master-push.yml index 7067395bc59..49acab52076 100644 --- a/.github/workflows/benchmark-master-push.yml +++ b/.github/workflows/benchmark-master-push.yml @@ -21,11 +21,11 @@ jobs: if: ${{ github.repository == 'gnolang/gno' }} runs-on: [self-hosted, Linux, X64, benchmarks] steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 1 - + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 1 + - uses: actions/setup-go@v5 with: go-version: "1.22.x" @@ -40,7 +40,7 @@ jobs: with: path: ./cache key: ${{ runner.os }}-benchmark - + - name: Store benchmark results into `gh-benchmarks` branch uses: benchmark-action/github-action-benchmark@v1 # see https://github.com/benchmark-action/github-action-benchmark?tab=readme-ov-file#action-inputs @@ -52,7 +52,7 @@ jobs: external-data-json-path: ./cache/benchmark-data.json max-items-in-chart: 100 # Show alert with commit comment on detecting possible performance regression - alert-threshold: '100%' + alert-threshold: '120%' fail-on-alert: true comment-on-alert: true alert-comment-cc-users: '@ajnavarro,@thehowl,@zivkovicmilos'