This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

RFC: Pull Requests Check List #1380

Open

8 tasks

DmitryBespalov opened this issue Dec 16, 2019 · 0 comments

Assignees

Labels

Contributor

DmitryBespalov commented Dec 16, 2019

I'd like to create a checklist for pull requests for quality improvement and easier code review.

Checklist for pull requests

Please check that screens are according to UI spec in Zeplin
Please check that code style is consistent
- Position of braces
- Spacing (whitespace, blank lines, after a comma, after the colon)
- Vertical alignment according to Xcode formatting
Unit tests exist and cover the changed or added functionality
Ambiguous code or design decisions documented with comments
Please double-check that the change does not insert new bugs into the system

DmitryBespalov added the maintenance label

DmitryBespalov assigned DmitryBespalov, MouazAlzahabi and sche

DmitryBespalov changed the title ~~Pull Requests Check List~~ RFC: Pull Requests Check List

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.