Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a new user, the heatmap does not render until you have submitted the first commit. #5151

Closed
1 of 6 tasks
tonysgi opened this issue Oct 23, 2018 · 3 comments · Fixed by #5154
Closed
1 of 6 tasks
Labels
Milestone

Comments

@tonysgi
Copy link

tonysgi commented Oct 23, 2018

  • Gitea version (or commit ref): 2ce72d4
  • Git version: 2.15.2
  • Operating system: Linux
  • Database (use [x]):
    • PostgreSQL
    • [x ] MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes - Create a new user to see bug
    • No
    • Not relevant
  • Log gist:

Description

As a new user, the heatmap does not render until you have submitted the first commit. Until that happens, it is perpetually displaying the "heatmap.loading" icon.

Screenshots

image

Originally posted by @tonysgi in #5131 (comment)

@kolaente
Copy link
Member

Normally it shouldn't show "heatmap.loading", there should be a text.

I think it doesn't load because the API returns null if the user has no actions yet, which the js library then fails to parse. I'll submit a patch tomorrow

@sapk
Copy link
Member

sapk commented Oct 23, 2018

@kolaente I already proposed a fix. You are right, it is because the array is not init (in the api reply) and the json representation is null not [].

@lunny lunny added the type/bug label Oct 24, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 24, 2018
@kolaente
Copy link
Member

@sapk Great! Thanks!

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants