No error message when trying to migrate repository with incorrect name

[mateusza]

When providing following incorrect values as target repository name used in migration, gitea returns 500 HTTP response code, and no proper error message is displayed.

• wrong.git

• ..

• Gitea version (or commit ref): ad86b84

• Git version: not relevant

• Operating system: not relevant

• Database (use [x]): not relevant

• Can you reproduce the bug at https://try.gitea.io:

  • Yes ( https://try.gitea.io/repo/migrate )
  • No
  • Not relevant

• Log gist:

Description

...

Screenshots

[mateusza]

And here is the log entry from my 1.7.3 instance:

2019/03/06 19:02:06 [...routers/repo/repo.go:146 handleCreateError()] [E] MigratePost: name pattern is not allowed [pattern: *.git]

[techknowlogick]

This issue has been raised before, however as I can't find the issue I am going to leave this open.

[jolheiser]

The issue with the same problem is #3799

The problem is these lines:

gitea/routers/repo/repo.go

Line 142 in ad86b84

case models.IsErrNamePatternNotAllowed(err):

gitea/routers/repo/repo.go

Line 265 in ad86b84

err = util.URLSanitizedError(err, remoteAddr)

More specifically the second one. When the error is "sanitized" it is no longer an ErrNamePatternNotAllowed, it is a urlSafeError and so Gitea returns a ServerError

gitea/modules/util/sanitize.go

Lines 22 to 26 in ad86b84

	// URLSanitizedError returns the sanitized version an error whose message may
	// contain a sensitive URL
	func URLSanitizedError(err error, unsanitizedURL string) error {
	return urlSafeError{err: err, unsanitizedURL: unsanitizedURL}
	}

I will try to get a PR in for this, and I'll probably add #6253 to it as well since they are for the same process and shouldn't be very big.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[stale]

This issue has been automatically closed because of inactivity. You can re-open it if needed.

[jolheiser]

Just a note, this issue was actually fixed by #6290