Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link in attribution #798

Closed
underspica opened this issue Aug 13, 2021 · 2 comments
Closed

Link in attribution #798

underspica opened this issue Aug 13, 2021 · 2 comments

Comments

@underspica
Copy link
Contributor

Is there a way to display link in attribution field like Mapbox or MapTiler?
I think this line escape all html tag: https://github.com/go-spatial/tegola/blob/v0.14.x/cmd/internal/register/maps.go#L14
@ARolek
Copy link
Member

ARolek commented Aug 13, 2021

@underspica I think you're right. We should probably have some form of sanitization but I think escaping HTML is the wrong thing to do there. Would you be interested in sending in a PR? We're really close to cutting the v0.14.0 release so you could probably sneak it in.

@underspica underspica mentioned this issue Aug 20, 2021
Merged
@underspica
Copy link
Contributor Author

Here is the PR #806
and some test cases https://play.golang.org/p/QL8w1w6xd54

@gdey gdey closed this as completed Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gdey @ARolek @underspica