Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add version to Queue Item #811

Closed
cognifloyd opened this issue May 17, 2023 · 1 comment · Fixed by go-vela/worker#478
Closed

enhance: Add version to Queue Item #811

cognifloyd opened this issue May 17, 2023 · 1 comment · Fixed by go-vela/worker#478
Labels
enhancement Indicates an improvement to a feature

Comments

@cognifloyd
Copy link
Member

Description

Add a version field or a versioned envelope to the queue Item.

Value

If a build gets queued and then the server+worker shut down for an upgrade (or a downgrade), then that build is "stale". The worker needs a way to handle this stale data gracefully. The worker should be able to reliably reject any queued items that it cannot handle (for example by failing the build).

Both of these proposals involve changing the queue Item or the underlying executable pipeline.Build. So,

Definition of Done

The queue Item has something that allows the worker to reject or fail the build if it cannot handle the version mismatch.

Effort (Optional)

1-3 days

Impacted Personas (Optional)

Vela admins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates an improvement to a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant