Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scm/webhook): change fork determination logic #1065

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Conversation

ecrupper
Copy link
Contributor

A PR build on a repo that is a fork of another repo is interpreted as "from a fork", even if the head and base are both from the same repo.

Fixed that and added tests.

@ecrupper ecrupper requested a review from a team as a code owner February 22, 2024 01:54
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@b0449f8). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1065   +/-   ##
=======================================
  Coverage        ?   62.40%           
=======================================
  Files           ?      345           
  Lines           ?    10257           
  Branches        ?        0           
=======================================
  Hits            ?     6401           
  Misses          ?     3382           
  Partials        ?      474           
Files Coverage Δ
scm/github/webhook.go 90.66% <100.00%> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 10db7c2 into main Feb 22, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the fix/pr-fork-logic branch February 22, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants