feat: use new version pkg #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockopp
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
==========================================
- Coverage 89.33% 88.95% -0.38%
==========================================
Files 108 108
Lines 2710 2708 -2
==========================================
- Hits 2421 2409 -12
- Misses 240 250 +10
Partials 49 49
|
wass3r
approved these changes
Oct 19, 2020
wass3r
requested changes
Oct 19, 2020
Comment on lines
70
to
74
| if gin.Mode() == "debug" { | ||
| c.Request.Header.Set("X-Vela-Version", apiVersion.String()) | ||
| c.Request.Header.Set("X-Vela-Version", v.Semantic()) | ||
| } else { // in prod we don't want the build number metadata | ||
| apiVersion.Metadata = "" | ||
| c.Request.Header.Set("X-Vela-Version", apiVersion.String()) | ||
| c.Request.Header.Set("X-Vela-Version", v.Semantic()) | ||
| } |
There was a problem hiding this comment.
do we need this if statement if we're returning the same thing?
There was a problem hiding this comment.
No, we don't need the if statement 👍
If you'd like I can comment out the if but I left it in favor of being explicit on how we could customize it in the future.
In short, my thought process was by leaving it there, if (or when) we want to look at customizing how that header is populated from the API when running in debug mode then the shell of the code is there.
There was a problem hiding this comment.
k, not a big deal to leave it in 👍
wass3r
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on go-vela/types#112
Updating to the new
go-vela/types/versionpackage to improve the information provided surrounding the application.If I compile the binary specifically for the OS on my workstation, I'm met with this from the
--versionflag:When I run
make uplocally, here is the output from http://localhost:8080/version:{ "canonical": "v0.6.1", "major": 0, "minor": 6, "patch": 1, "metadata": { "architecture": "amd64", "build_date": "2020-10-16T09:15:43Z", "compiler": "gc", "git_commit": "44c10cfa6b25f02721609cccd2fbcedea0109f7b", "go_version": "go1.15.2", "operating_system": "linux" } }NOTE: This also updates the GitHub Actions pipelines to use our
makecommands for building the binary.