Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: adding a branch field to scheduled builds #934

Merged
merged 7 commits into from
Aug 23, 2023

Conversation

claire1618
Copy link
Contributor

No description provided.

@claire1618 claire1618 requested a review from a team as a code owner August 22, 2023 14:55
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #934 (b40801b) into main (6874831) will decrease coverage by 0.03%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
- Coverage   70.92%   70.89%   -0.03%     
==========================================
  Files         310      310              
  Lines       12740    12745       +5     
==========================================
  Hits         9036     9036              
- Misses       3250     3255       +5     
  Partials      454      454              
Files Changed Coverage Δ
api/schedule/create.go 14.07% <0.00%> (-0.43%) ⬇️
api/schedule/update.go 0.00% <0.00%> (ø)
database/schedule/table.go 100.00% <ø> (ø)
scm/github/repo.go 76.34% <100.00%> (ø)

api/schedule/create.go Outdated Show resolved Hide resolved
KellyMerrick
KellyMerrick previously approved these changes Aug 22, 2023
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

api/schedule/update.go Outdated Show resolved Hide resolved
@claire1618 claire1618 merged commit a980c86 into main Aug 23, 2023
12 of 13 checks passed
@claire1618 claire1618 deleted the enhance/scheduledBuildBranches branch August 23, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants