feat: add version pkg for Vela #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
=======================================
Coverage 99.20% 99.20%
=======================================
Files 46 48 +2
Lines 2759 2784 +25
=======================================
+ Hits 2737 2762 +25
Misses 12 12
Partials 10 10
|
jbrockopp
changed the title
jbrockopp
commented
Oct 16, 2020
| GitCommit: %s, | ||
| GoVersion: %s, | ||
| OperatingSystem: %s, | ||
| }` |
There was a problem hiding this comment.
This is the format if we were to output the Metadata from the struct.
| GoVersion: %s, | ||
| OperatingSystem: %s, | ||
| } | ||
| }` |
There was a problem hiding this comment.
This is the format if we were to output the entire Version struct.
| // Meta implements a formatted string containing only metadata for the Version type. | ||
| func (v *Version) Meta() string { | ||
| return v.Metadata.String() | ||
| } |
There was a problem hiding this comment.
Here is the function used to return only the Metadata from the version.
| // Semantic implements a formatted string containing a formal semantic version for the Version type. | ||
| func (v *Version) Semantic() string { | ||
| return v.Canonical | ||
| } |
There was a problem hiding this comment.
Here is the function used to return only the canonical reference of the semantic version.
This was referenced Oct 16, 2020
wass3r
approved these changes
Oct 16, 2020
This was referenced Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing a custom
Versiontype for Vela that can be referenced throughout the different repos.When rendered as JSON the output looks like:
{ "canonical": "v1.2.3", "major": 1, "minor": 2, "patch": 3, "metadata": { "architecture": "amd64", "build_date": "1970-1-1T00:00:00Z", "compiler": "gc", "git_commit": "abcdef123456789", "go_version": "1.15.0", "operating_system": "linux" } }Beyond the
String()functions, this package also supports two different functions:Meta()- returns only the metadata surrounding the version of the applicationSemantic()- returns only the canonical semantic version of the application