Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schedules): correct encoding of update schedule payload for active field #683

Merged
merged 1 commit into from
Jun 22, 2023
Merged

fix(schedules): correct encoding of update schedule payload for active field #683

merged 1 commit into from
Jun 22, 2023

Conversation

ecrupper
Copy link
Contributor

Calls to enable/disable an existing schedule in the UI do not work because the payload is encoded as enabled: bool rather than active: bool.

@ecrupper ecrupper self-assigned this Jun 22, 2023
@ecrupper ecrupper requested a review from a team as a code owner June 22, 2023 15:45
@plyr4
Copy link
Contributor

plyr4 commented Jun 22, 2023

good catch. separate but related, should we change the wording in the UI to make it more accurate?
https://github.com/go-vela/ui/blob/main/src/elm/Pages/Schedules/View.elm#L130 etc

@ecrupper ecrupper merged commit d22fc4a into main Jun 22, 2023
12 checks passed
@ecrupper ecrupper deleted the fix-correct-update-schedule-encode branch June 22, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhuynh94 timhuynh94 timhuynh94 approved these changes

@plyr4 plyr4 plyr4 approved these changes

Assignees

@ecrupper ecrupper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecrupper @plyr4 @timhuynh94