Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: admin page for workers and db driven platform settings #794

Merged
merged 63 commits into from
May 14, 2024
Merged

feat: admin page for workers and db driven platform settings #794

merged 63 commits into from
May 14, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Apr 25, 2024 •
edited
Loading

see: go-vela/server#1110

admin/workers

Screenshot 2024-04-26 at 4 50 53 PM

admin/settings

Screenshot 2024-04-26 at 4 50 46 PM

plyr4 and others added 30 commits March 26, 2024 14:15
@plyr4
chore: reorder types to appease elm-land
2162736
@plyr4
chore: rename vars to appease elm-land
880e93c
@plyr4
chore: remove func from elm-land static code
2b1cc3c
@plyr4
chore: move helper out of generated file
727d977
@plyr4
chore: move helper out of generated file
7723fbc
@plyr4
chore: rename helper
ec84f4b
@plyr4
fix: alias routes
ef1b03d
@plyr4
chore: add stub pages for pageless routes
82624ab
@plyr4
chore: add stub pages for pageless routes
3066355
@plyr4
chore: run generate against Main.elm
5d8bfe5
@plyr4
fix: use Page init to redirect using query params
00ab8d1
@plyr4
fix: use Page init to handle authentication flow
98c2d24
@plyr4
fix: elm generate whiteline
94b5551
@plyr4
fix: use static path vars for aliases
5438f15
@ecrupper
init commit
8a9cadc
@plyr4
feat: admin layout with split pages
f1d7e90
@plyr4
feat: admin layout with non admin protection
422eafc
@plyr4
tweak: loader no text
7065eb1
@plyr4
fix: fetch shared user also
f75705b
@plyr4
tweak: comment
b527e0e
@plyr4
chore: remove settings tab
6a69454
@plyr4
feat: re-add settings page
2d53ede
@plyr4
Merge branch 'main' of github.com:go-vela/ui into admin-page-settings
a528b22
@plyr4
Merge branch 'main' of github.com:go-vela/ui into admin-page
8e5d2b4
@plyr4
feat: settings page, api, types
3058e9a
@plyr4
wip: admin settings page with clone image
4208e7f
@plyr4
tweak: move admin link to top right
56a385b
@plyr4
Merge branch 'admin-page' of github.com:go-vela/ui into admin-page-se…
022e7ea 
…ttings
@plyr4
wip: admin platform settings tab
9829f78
@plyr4
chore: merge with main
60a99ae
@plyr4 plyr4 marked this pull request as ready for review April 29, 2024 19:24
@plyr4 plyr4 requested a review from a team as a code owner April 29, 2024 19:24
@plyr4 plyr4 changed the title feat: page for db driven platform settings feat: admin page for workers and db driven platform settings Apr 29, 2024
@plyr4
Copy link
Contributor Author

plyr4 commented May 3, 2024

Screenshot 2024-05-03 at 4 10 21 PM
  • added "Before:" element to capture and show the previous value when something is updated.
  • added "last updated by" to the bottom

wass3rw3rk
wass3rw3rk reviewed May 13, 2024
View reviewed changes
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple small things.. looking good

src/scss/_table.scss Outdated Show resolved Hide resolved
src/elm/Pages/Admin/Workers.elm Outdated Show resolved Hide resolved
ecrupper
ecrupper previously approved these changes May 13, 2024
View reviewed changes
wass3r
wass3r previously approved these changes May 14, 2024
View reviewed changes
@plyr4 plyr4 dismissed stale reviews from wass3r and ecrupper via 89efdf4 May 14, 2024 13:49
@plyr4 plyr4 merged commit 530d896 into main May 14, 2024
13 checks passed
@plyr4 plyr4 deleted the admin-page-settings branch May 14, 2024 14:53
@plyr4 plyr4 mentioned this pull request Jul 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wass3rw3rk wass3rw3rk wass3rw3rk approved these changes

@ecrupper ecrupper ecrupper approved these changes

@wass3r wass3r wass3r left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plyr4 @wass3r @wass3rw3rk @ecrupper