-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: license tweaks to improve maintainability #41
Conversation
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
=======================================
Coverage 21.46% 21.46%
=======================================
Files 3 3
Lines 452 452
=======================================
Hits 97 97
Misses 353 353
Partials 2 2
|
@@ -186,7 +186,7 @@ APPENDIX: How to apply the Apache License to your work. | |||
same "printed page" as the copyright notice for easier | |||
identification within third-party archives. | |||
|
|||
Copyright (c) 2023 Target Brands, Inc. | |||
Copyright 2019 Target Brands, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we drop the year altogether?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
summary: remove redundant and unnecessary shield and remove copyright note since it's already in the license.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
summary: update linter to use new format for code files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
summary: format is changed to match Copyright [yyyy] [name of copyright owner]
as shown here: https://www.apache.org/licenses/LICENSE-2.0.html. in other words, just dropping the redundant (c)
. the year roughly matches that of Vela release, but maybe this should match first publish of the code in this repo in which case all repos might end up with different years.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
summary: changed copyright metadata fed into CLI lib to mention license instead.
separate PR incoming |
No description provided.