Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: license tweaks to improve maintainability #41

Closed
wants to merge 1 commit into from

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Mar 17, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #41 (2308237) into main (e656565) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   21.46%   21.46%           
=======================================
  Files           3        3           
  Lines         452      452           
=======================================
  Hits           97       97           
  Misses        353      353           
  Partials        2        2           
Impacted Files Coverage Δ
cmd/vela-email/loginauth.go 0.00% <ø> (ø)
cmd/vela-email/main.go 0.00% <0.00%> (ø)
cmd/vela-email/plugin.go 54.49% <ø> (ø)

@@ -186,7 +186,7 @@ APPENDIX: How to apply the Apache License to your work.
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright (c) 2023 Target Brands, Inc.
Copyright 2019 Target Brands, Inc.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we drop the year altogether?

Copy link
Member

@wass3rw3rk wass3rw3rk Mar 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summary: remove redundant and unnecessary shield and remove copyright note since it's already in the license.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summary: update linter to use new format for code files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summary: format is changed to match Copyright [yyyy] [name of copyright owner] as shown here: https://www.apache.org/licenses/LICENSE-2.0.html. in other words, just dropping the redundant (c). the year roughly matches that of Vela release, but maybe this should match first publish of the code in this repo in which case all repos might end up with different years.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summary: changed copyright metadata fed into CLI lib to mention license instead.

@wass3rw3rk
Copy link
Member

separate PR incoming

@wass3rw3rk wass3rw3rk closed this Sep 8, 2023
@wass3rw3rk wass3rw3rk deleted the chore/license-tweaks branch September 22, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants